Do not ignore engines #1236
Merged
Do not ignore engines #1236
+48
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Mar 9, 2017
ksp_plugin/plugin.hpp
Outdated
| // union-find for pile up construction. This must be called after the calls | ||
| // to |IncrementPartIntrinsicForce|, and before the calls to | ||
| // |ReportCollision|. | ||
| virtual void BeginReportingCollisions(); |
There was a problem hiding this comment.
The name is a bit of a misnomer, it doesn't "begin" anything. How about PrepareToReportCollisions?
ksp_plugin/plugin.cpp
Outdated
| @@ -492,6 +487,22 @@ void Plugin::IncrementPartIntrinsicForce(PartId const part_id, | |||
| vessel->part(part_id)->increment_intrinsic_force(WorldToBarycentric()(force)); | |||
| } | |||
|
|
|||
| void Plugin::BeginReportingCollisions() { | |||
| for (not_null<Vessel*>vessel:loaded_vessels_) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engines are now taken into account correctly, and conservation of momentum is otherwise enforced. Stage separation appears to work, however it also seems to jettison the camera for a while. This needs to be looked into.