Update python.md #23669
Merged
Update python.md #23669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes it clear how to alter `attributes` by using `packageOverrides`
|
@qknight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @alexeymuranov and @bennofs to be potential reviewers. |
bennofs
reviewed
Mar 9, 2017
doc/languages-frameworks/python.md
Outdated
|
|
||
| ```nix | ||
| nixpkgs.config.packageOverrides = super: { | ||
| pythonPackages = super.pythonPackages // { bepasty-server = super.python27Packages.bepasty-server.overrideAttrs (oldAttrs: { |
There was a problem hiding this comment.
not quite sure if we should recommend this, since this will not affect dependent python packages. A better approach is this, I believe:
pythonPackages = super.pythonPackages.override {
overrides = self: super: {
bepasty-server = super.bepasty-server.overrideAttrs { ... }
};
}
FRidh
requested changes
Mar 9, 2017
doc/languages-frameworks/python.md
Outdated
| src = pkgs.fetchgit { | ||
| url = "https://github.com/bepasty/bepasty-server"; | ||
| sha256 = "9ziqshmsf0rjvdhhca55sm0x8jz76fsf2q4rwh4m6lpcf8wr0nps"; | ||
| #sha256 = "5ziqshmsf0rjvdhhca55sm0x8jz76fsf2q4rwh4m6lpcf8wr0nps"; |
There was a problem hiding this comment.
remove old urls and fix indentation
|
A couple more comments:
|
|
|
thanks everyone for the feedback! |
globin
pushed a commit
that referenced
this pull request
Mar 21, 2017
* Update python.md this makes it clear how to alter `attributes` by using `packageOverrides` * Update python.md * Update python.md * Update python.md * Update python.md * Update python.md * Update python.md (cherry picked from commit 91debcb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes it clear how to alter
attributesby usingpackageOverrides