Update ds4drv & deps #23664
Merged
Update ds4drv & deps #23664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joachifm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fignuts, @globin, @DamienCassou and @FRidh to be potential reviewers. |
|
(Note that I don't use these packages myself ...) |
Mic92
reviewed
Mar 9, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -21202,11 +21202,11 @@ in { | |||
|
|
|||
| pyudev = buildPythonPackage rec { | |||
There was a problem hiding this comment.
If you have the time, please also move this package to an external file in ./pkgs/development/python-modules. This is currently what we do with every python package update.
|
@Mic92 I've moved the expressions. Does it look okay to you? If so I'll squash this up and integrate it. |
Mic92
approved these changes
Mar 11, 2017
Also move expression
Also move expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #16313