Advance parts #1260
Merged
Advance parts #1260
+133
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Mar 15, 2017
| @@ -585,9 +585,7 @@ void Plugin::SetPartApparentDegreesOfFreedom( | |||
| part, world_to_apparent_bubble(degrees_of_freedom)); | |||
| } | |||
|
|
|||
| void Plugin::AdvanceTime(Instant const& t, Angle const& planetarium_rotation) { | |||
| VLOG(1) << __FUNCTION__ << '\n' | |||
There was a problem hiding this comment.
May be keep the VLOG for the time?
There was a problem hiding this comment.
We never actually use the VLOGs, we either journal or add ad hoc traces.
serialization/journal.proto
Outdated
| } | ||
| optional In in = 1; | ||
| } | ||
|
|
||
| message PrepareToReportCollisions { |
There was a problem hiding this comment.
This message doesn't seem to be in alphabetical order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at putting those calls in the right order.