Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ponyc: 0.11.0 -> 0.11.3 #23898

Merged
merged 1 commit into from Mar 17, 2017
Merged

ponyc: 0.11.0 -> 0.11.3 #23898

merged 1 commit into from Mar 17, 2017

Conversation

kamilchm
Copy link
Member

Motivation for this change

ponylang/ponyc#1659

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@kamilchm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @doublec, @dipinhora and @wizeman to be potential reviewers.

@dezgeg
Copy link
Contributor

dezgeg commented Mar 15, 2017

I get:

Error:
/tmp/nix-build-pony-stable-2016-10-10.drv-0/pony-stable-fdefa26fed93f4ff81c323f29abd47813c515703-src/stable/main.pony:67:9: argument not a subtype of parameter
        ["env", "PONYPATH="+ponypath].append(rest), env~exitcode()
        ^
    Info:
    /nix/store/zc000mvg5vvwsgm4m3vidfnlj6c2w3sc-ponyc-0.11.1/lib/pony/0.11.1/packages/builtin/array.pony:266:3: None val is not a subtype of Array[String val] box
      fun ref append(seq: (ReadSeq[A] & ReadElement[A^]), offset: USize = 0,
      ^
Error:
/tmp/nix-build-pony-stable-2016-10-10.drv-0/pony-stable-fdefa26fed93f4ff81c323f29abd47813c515703-src/stable/shell.pony:30:30: argument not a subtype of parameter
    "'" + arg.clone().replace("'", "'\\''") + "'"
                             ^
    Info:
    /nix/store/zc000mvg5vvwsgm4m3vidfnlj6c2w3sc-ponyc-0.11.1/lib/pony/0.11.1/packages/builtin/string.pony:928:68: USize val is not a subtype of String box
      fun ref replace(from: String box, to: String box, n: USize = 0): USize =>
                                                                       ^
make: *** [Makefile:15: bin/stable] Error 255
builder for ‘/nix/store/81qyaxgkbx73grwvp582la7dbjb3s64h-pony-stable-2016-10-10.drv’ failed with exit code 2

@kamilchm
Copy link
Member Author

I'll look at pony-stable tomorrow. Thx for pointing it out.

@kamilchm kamilchm changed the title ponyc: 0.11.0 -> 0.11.1 ponyc: 0.11.0 -> 0.11.2 Mar 16, 2017
@kamilchm
Copy link
Member Author

kamilchm commented Mar 16, 2017 •
edited

Updated ponyc to 0.11.3 + newest pony-stable-unstable 😃

@kamilchm kamilchm changed the title ponyc: 0.11.0 -> 0.11.2 ponyc: 0.11.0 -> 0.11.3 Mar 17, 2017
@globin globin merged commit 017fddb into NixOS:master Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizeman wizeman wizeman approved these changes

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kamilchm @mention-bot @dezgeg @wizeman @matthiasbeyer @joachifm @globin