Haskell/just static executables #23607
Conversation
|
@domenkozar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @mboes and @shajra to be potential reviewers. |
| enableSharedExecutables = false; | ||
| isLibrary = false; | ||
| doHaddock = false; | ||
| postFixup = "rm -rf $out/lib $out/nix-support $out/share/doc"; |
There was a problem hiding this comment.
Should we really delete $out/share/doc here? What if the package includes manpages or other user-facing documentation? We can probably delete $out/share/doc/*-ghc-${ghc.version} though, but since haddocks are disabled, shouldn't that not exist already?
There was a problem hiding this comment.
@bennofs to be honest, I just used what was already there. I don't know the reasoning behind the doc removal, but we could probably check with existing code what is left behind it that folder isn't deleted. If haddock is removed, I don't see no harm deleting also the whole doc folder.
There was a problem hiding this comment.
Don't manpages end up in $out/share/man? I wouldn't think there's anything important in doc for an executable.
|
I assume this is related to #22810. |
|
@LnL7 nope, it's just reducing closure size. |
| enableSharedExecutables = false; | ||
| isLibrary = false; | ||
| doHaddock = false; | ||
| postFixup = "rm -rf $out/lib $out/nix-support $out/share/doc"; |
There was a problem hiding this comment.
Don't manpages end up in $out/share/man? I wouldn't think there's anything important in doc for an executable.
This code was getting copy-pasted in 4 places so I factored it out.
cc @peti @copumpkin @LnL7