Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

racket: add readline support #23613

Merged
merged 1 commit into from Mar 9, 2017
Merged

Conversation

henrytill
Copy link
Member

Motivation for this change

Currently, Racket gives the following warning upon startup:

; Warning: no readline support (ffi-lib: couldn't open "libedit.so.3" (libedit.so.3: cannot open shared object file: No such file or directory))

This PR adds libedit as a dependency, thus enabling readline support and silencing the warning.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@henrytill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aske, @gridaphobe and @letac to be potential reviewers.

@Mic92 Mic92 merged commit f3850a0 into NixOS:master Mar 9, 2017
@Mic92
Copy link
Member

Mic92 commented Mar 9, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants