haskellPackages: apply GHC specific overrides before GHCJS #23610
Conversation
|
@ljli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @cstrahan and @Profpatsch to be potential reviewers. |
pkgs/top-level/haskell-packages.nix
Outdated
| compilerConfig = | ||
| extendCompose | ||
| (callPackage ../development/haskell-modules/configuration-ghcjs.nix { }) | ||
| (callPackage ../development/haskell-modules/configuration-ghc-7.10.x.nix { }); |
There was a problem hiding this comment.
Why don't you pass the ghc-7.10.x-related overrides as packageSetConfig here? That would rectify the need for function composition.
There was a problem hiding this comment.
I noticed that packageSetConfig could be used, but I wasn't sure it was intended for this and compilerConfig sounds more fitting than packageSetConfig. Alternatively we could introduce a new argument compilerBackendConfig or make the *Config arguments take lists of configs. Anyway I'm gonna update the PR according to your suggestion.
pkgs/top-level/haskell-packages.nix
Outdated
| @@ -15,6 +15,8 @@ let # These are attributes in compiler and packages that don't support integer-s | |||
| "uhc" | |||
| "integer-simple" | |||
| ]; | |||
| extendCompose = a: b: self: super: let super' = b self super; in super' // a self (super // super'); | |||
There was a problem hiding this comment.
This function belongs into lib/trivial.nix.
GHCJS is effectively a backend for GHC, so all the GHC version specific package set overrides should in general apply to the GHCJS package sets, too.
ljli
force-pushed
the
hs-ghcjs-pkgs-inherit
branch
from
eb1d589
to
b9c7d29
Compare
|
I updated the PR, are we good? |
GHCJS is effectively a backend for GHC, so all the GHC version specific package set overrides should in
general apply to the GHCJS package sets, too.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)