Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hplip: Adds missing depdency sip #37907

Closed
wants to merge 1 commit into from
Closed

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Mar 27, 2018

Motivation for this change

Fixes: #37857

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@cx405
Copy link

cx405 commented Mar 27, 2018

Wow, just noticed this absolutely randomly. Thank you very much, @bkchr!

@bkchr
Copy link
Contributor Author

bkchr commented Mar 27, 2018

I just wanted to print for myself and observed that it did not work :D I found your issue while searching for the error message :)

@bkchr
Copy link
Contributor Author

bkchr commented Mar 28, 2018

@jgeerds @ttuegel anyone could merge this?

@bjornfor
Copy link
Contributor

Applied to master (8152db9).

Should it be backported? To 18.03 and 17.09?

@bjornfor bjornfor closed this Mar 29, 2018
@bkchr
Copy link
Contributor Author

bkchr commented Mar 29, 2018

I think it needs to be backported to 18.03. I'm unsure about 17.09, because I don't know when it stopped working.

@bjornfor
Copy link
Contributor

Cherry-picked to release-18.03 (fbc2cb7).

@cx405
Copy link

cx405 commented Mar 29, 2018

@bjornfor @bkchr the 17.09 had the same situation. The deal is - while its possible to add the printer via CUPS inteface, its done via PPD, so basically the hplip is dead without this. I need yet to test if this actually fixes it or there are additional stuff missing.

Obviously "hp-doctor" will be broken by the very design of NixOS, however if hplip-gui starts and capable to add/detect consequences with printer/scanner/fax we are fine.

I also noted that:

  1. printer will refuse to print any "custom paper", which is available through GIMP menu for example.
  2. GIMP preview creates HUGE offset fields on some paper formats, however they are not printed
  3. Qt-based applications, such as Okular refuse to accept some paper types - which is very similar to this: https://forum.kde.org/viewtopic.php?f=289&t=136325

@bkchr
Copy link
Contributor Author

bkchr commented Mar 29, 2018

@cx405 I could add my printer with this this patch.

@cx405
Copy link

cx405 commented Mar 29, 2018

@bkchr Could I ask you how did you import the patched hplip? I am on 18.03 and doing:

{ config, pkgs, ... }:
let master = import <nixos-master> {}; in
{
...
services.printing.drivers = with pkgs; [ master.hplip ];
...
}

with

# nix-channel --list
nixos https://nixos.org/channels/nixos-18.03
nixos-master https://nixos.org/channels/nixos-unstable

leads to 1Gb pull of duplicate libraries. Could I ask you about advice for this type of per-package upgrade? I have HP Officejet pro 8600 (n911a).

@bkchr
Copy link
Contributor Author

bkchr commented Mar 29, 2018

I'm following the master branch of nixpkgs as my channel. You will probably need to wait for unstable or unstable-small to contain the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants