Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.spdx: fix build #37910

Merged
merged 1 commit into from Mar 31, 2018
Merged

haskellPackages.spdx: fix build #37910

merged 1 commit into from Mar 31, 2018

Conversation

maximedenes
Copy link
Contributor

Motivation for this change

Building this package was failing. Some other packages depend on it, like purescript.
We disable tests which depend on old tasty (< 0.12).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@maximedenes maximedenes requested a review from peti as a code owner March 27, 2018 11:30
peti
peti requested changes Mar 27, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please report that issue upstream and add a link to the ticket into the code over the override so that other people have a simple way of tracking whether the issue still exists.

@maximedenes
Copy link
Contributor Author

@peti This has already been fixed upstream: phadej/spdx@4288df6

but no released version includes this commit yet.

What should I do?

@peti
Copy link
Member

peti commented Mar 27, 2018

In that case, please record the version number of spdx that shows this issue in a comment and mention that this has already been fixed in git.

@maximedenes
haskellPackages.spdx: fix build
a1e8bd3 
We disable tests which depend on old tasty (< 0.12).
@maximedenes
Copy link
Contributor Author

@peti comment added, thanks for the suggestion

@peti peti merged commit d44d359 into NixOS:master Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maximedenes @peti @GrahamcOfBorg