Openclonk 8.1 #37908

lheckemann · 2018-03-27T10:53:20Z

Motivation for this change

New upstream version

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-03-27T11:06:10Z

Failure on x86_64-darwin (full log)

Attempted: openclonk

Partial log (click to expand)

  Aborting.
Call Stack (most recent call first):
  CMakeLists.txt:190 (REQUIRE_CXX_SOURCE_COMPILES)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-openclonk-8.1.drv-0/openclonk-release-8.1-src/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-openclonk-8.1.drv-0/openclonk-release-8.1-src/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/g1m6lghcbw3zam5aagnrmhxlaiyaqcya-openclonk-8.1.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/g1m6lghcbw3zam5aagnrmhxlaiyaqcya-openclonk-8.1.drv' failed

GrahamcOfBorg · 2018-03-27T11:07:16Z

Failure on aarch64-linux (full log)

Attempted: openclonk

Partial log (click to expand)

  if (!scale[0]) scale[0] = 10; if (!scale[1]) scale[1] = 10;
  ^~
/build/openclonk-release-8.1-src/src/landscape/C4MapScriptAlgo.cpp:376:32: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  if (!scale[0]) scale[0] = 10; if (!scale[1]) scale[1] = 10;
                                ^~
[ 12%] Linking CXX static library liblibopenclonk.a
[ 12%] Built target libopenclonk
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/il84z1072fccxl9ffnd6iv5y0vja9qrh-openclonk-8.1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/il84z1072fccxl9ffnd6iv5y0vja9qrh-openclonk-8.1.drv' failed

GrahamcOfBorg · 2018-03-27T11:09:20Z

Success on x86_64-linux (full log)

Attempted: openclonk

Partial log (click to expand)

renamed '/nix/store/888z2kr3hgflhsd98mv8pi5g2v9qn4xg-openclonk-8.1/games/openclonk' -> '/nix/store/888z2kr3hgflhsd98mv8pi5g2v9qn4xg-openclonk-8.1/bin/openclonk'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/888z2kr3hgflhsd98mv8pi5g2v9qn4xg-openclonk-8.1
shrinking /nix/store/888z2kr3hgflhsd98mv8pi5g2v9qn4xg-openclonk-8.1/bin/c4group
shrinking /nix/store/888z2kr3hgflhsd98mv8pi5g2v9qn4xg-openclonk-8.1/bin/openclonk
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/888z2kr3hgflhsd98mv8pi5g2v9qn4xg-openclonk-8.1/bin
patching script interpreter paths in /nix/store/888z2kr3hgflhsd98mv8pi5g2v9qn4xg-openclonk-8.1
checking for references to /build in /nix/store/888z2kr3hgflhsd98mv8pi5g2v9qn4xg-openclonk-8.1...
/nix/store/888z2kr3hgflhsd98mv8pi5g2v9qn4xg-openclonk-8.1

lheckemann · 2018-03-29T14:23:34Z

@lluchs you might care about this?

lluchs · 2018-03-30T16:28:46Z

Thanks for updating OpenClonk! The overall result is exactly what we expect to happen. OC on Mac doesn't work because we currently don't have any Mac developers (although it does build successfully with XCode, I don't know what's wrong with nix's clang). While we fixed the issue with requiring SSE on all platforms, OC won't work on ARM in any case because OC requires OpenGL 3.2, but there is only OpenGL ES available there.

So I suggest you disable building openclonk on everything but x86 Linux.

lheckemann · 2018-04-10T07:44:49Z

OC requires OpenGL 3.2, but there is only OpenGL ES available there.

Not necessarily. There's no technical reason a PCIe graphics card couldn't be used with an ARM board, or for the graphics drivers for whatever built-in graphics acceleration there is not to support OpenGL. I'll rerun the builds so I can see the logs for arm and maybe fix the build if it's easy.

GrahamcOfBorg · 2018-04-10T07:59:02Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openclonk

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-04-10T08:01:55Z

Failure on aarch64-linux (full log)

Attempted: openclonk

Partial log (click to expand)

/build/openclonk-release-8.1-src/src/lib/C4InputValidation.cpp:62:3: note: here
   case VAL_FullPath:        // full filename paths
   ^~~~
[ 12%] Linking CXX static library liblibmisc.a
[ 12%] Built target libmisc
[ 12%] Linking CXX static library liblibopenclonk.a
[ 12%] Built target libopenclonk
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/cyjpx32kc2sxn4yv4k1y7i12lawy000n-openclonk-8.1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/cyjpx32kc2sxn4yv4k1y7i12lawy000n-openclonk-8.1.drv' failed

GrahamcOfBorg · 2018-04-10T08:05:26Z

Success on x86_64-linux (full log)

Attempted: openclonk

Partial log (click to expand)

renamed '/nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1/games/openclonk' -> '/nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1/bin/openclonk'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1
shrinking /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1/bin/c4group
shrinking /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1/bin/openclonk
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1/bin
patching script interpreter paths in /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1
checking for references to /tmp/nix-build-openclonk-8.1.drv-0 in /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1...
/nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1

lheckemann · 2018-04-10T08:53:12Z

So the issue is that the BLAKE2 implementation is the SSE one which assumes at least SSE2, which isn't available on ARM. This shouldn't be too hard to fix but it should probably be done upstream. I've just disabled aarch64 for now.

GrahamcOfBorg · 2018-04-10T09:09:37Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openclonk

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-04-10T09:09:57Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: openclonk

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-04-10T09:14:06Z

Success on x86_64-linux (full log)

Attempted: openclonk

Partial log (click to expand)

renamed '/nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1/games/openclonk' -> '/nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1/bin/openclonk'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1
shrinking /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1/bin/c4group
shrinking /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1/bin/openclonk
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1/bin
patching script interpreter paths in /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1
checking for references to /build in /nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1...
/nix/store/61hjqk5n277fm5mms79iks2axn4c5ad7-openclonk-8.1

lheckemann · 2018-04-10T11:55:25Z

For the BLAKE2 issue,
upstream issue
debian patch

In the meantime, there shouldn't be any further obstacles to merging.

lheckemann force-pushed the openclonk-8.1 branch from b1cf8a3 to fcf62ae Compare March 27, 2018 10:53

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 27, 2018

lheckemann force-pushed the openclonk-8.1 branch from fcf62ae to c46f3b3 Compare April 10, 2018 07:47

GrahamcOfBorg added 8.has: clean-up 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 1-10 labels Apr 10, 2018

openclonk: 7.0 -> 8.1

ea1a167

lheckemann force-pushed the openclonk-8.1 branch from c46f3b3 to ea1a167 Compare April 10, 2018 08:51

Mic92 merged commit 997ead8 into NixOS:master Apr 14, 2018

lheckemann deleted the openclonk-8.1 branch April 14, 2018 21:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Openclonk 8.1 #37908

Openclonk 8.1 #37908

lheckemann commented Mar 27, 2018

GrahamcOfBorg commented Mar 27, 2018

GrahamcOfBorg commented Mar 27, 2018

GrahamcOfBorg commented Mar 27, 2018

lheckemann commented Mar 29, 2018

lluchs commented Mar 30, 2018 •

edited

lheckemann commented Apr 10, 2018 •

edited

GrahamcOfBorg commented Apr 10, 2018

GrahamcOfBorg commented Apr 10, 2018

GrahamcOfBorg commented Apr 10, 2018

lheckemann commented Apr 10, 2018 •

edited

GrahamcOfBorg commented Apr 10, 2018

GrahamcOfBorg commented Apr 10, 2018

GrahamcOfBorg commented Apr 10, 2018

lheckemann commented Apr 10, 2018

Openclonk 8.1 #37908

Openclonk 8.1 #37908

Conversation

lheckemann commented Mar 27, 2018

Motivation for this change

Things done

GrahamcOfBorg commented Mar 27, 2018

GrahamcOfBorg commented Mar 27, 2018

GrahamcOfBorg commented Mar 27, 2018

lheckemann commented Mar 29, 2018

lluchs commented Mar 30, 2018 • edited

lheckemann commented Apr 10, 2018 • edited

GrahamcOfBorg commented Apr 10, 2018

GrahamcOfBorg commented Apr 10, 2018

GrahamcOfBorg commented Apr 10, 2018

lheckemann commented Apr 10, 2018 • edited

GrahamcOfBorg commented Apr 10, 2018

GrahamcOfBorg commented Apr 10, 2018

GrahamcOfBorg commented Apr 10, 2018

lheckemann commented Apr 10, 2018

lluchs commented Mar 30, 2018 •

edited

lheckemann commented Apr 10, 2018 •

edited

lheckemann commented Apr 10, 2018 •

edited