mesos: fix on darwin by disabling java interface #38468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: darwin
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: mesos Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: mesos Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: mesos Partial log (click to expand)
|
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: mesos Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: mesos Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: mesos Partial log (click to expand)
|
LnL7
suggested changes
Apr 5, 2018
| @@ -46,11 +47,13 @@ in stdenv.mkDerivation rec { | |||
| autoreconfHook | |||
| ]; | |||
| buildInputs = [ | |||
| makeWrapper curl sasl jdk | |||
| makeWrapper curl sasl | |||
| python wrapPython boto setuptools leveldb | |||
There was a problem hiding this comment.
Looks like leveldb doesn't have a correct install_name.
$ ./result/bin/mesos --help
dyld: Library not loaded: /private/tmp/nix-build-leveldb-1.18.drv-0/source/libleveldb.dylib.1
Referenced from: /src/nixpkgs/./result/bin/mesos
Reason: image not found
|
Success on aarch64-linux (full log) Attempted: leveldb The following builds were skipped because they don't evaluate on aarch64-linux: mesos Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: leveldb, mesos Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: leveldb, mesos Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: leveldb, mesos Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: leveldb The following builds were skipped because they don't evaluate on aarch64-linux: mesos Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: leveldb, mesos Partial log (click to expand)
|
LnL7
reviewed
Apr 5, 2018
| @@ -15,7 +15,12 @@ stdenv.mkDerivation rec { | |||
| make all leveldbutil libmemenv.a | |||
| ''; | |||
|
|
|||
| installPhase = " | |||
| installPhase = (stdenv.lib.optionalString stdenv.isDarwin '' | |||
There was a problem hiding this comment.
FYI. there's a fixDarwinDylibNames helper that basically does this for you.
There was a problem hiding this comment.
Oh! Thank you! I actually knew about this, but could not remember how to find that name. I will try to update now.
There was a problem hiding this comment.
@LnL7
It doesn't quite work for libleveldb:
% otool -D $(nix-build -A leveldb .)/lib/lib*dylib*
/nix/store/d1hyikxwzcvzbqj9x6mqqsf9xs91lbj2-leveldb-1.18/lib/libleveldb.dylib:
/nix/store/d1hyikxwzcvzbqj9x6mqqsf9xs91lbj2-leveldb-1.18/lib/libleveldb.dylib
/nix/store/d1hyikxwzcvzbqj9x6mqqsf9xs91lbj2-leveldb-1.18/lib/libleveldb.dylib.1:
/private/var/folders/1f/2mj_ng1n2y3_wc59fgw3fn_r0000gn/T/nix-build-leveldb-1.18.drv-0/source/libleveldb.dylib.1
/nix/store/d1hyikxwzcvzbqj9x6mqqsf9xs91lbj2-leveldb-1.18/lib/libleveldb.dylib.1.18:
/private/var/folders/1f/2mj_ng1n2y3_wc59fgw3fn_r0000gn/T/nix-build-leveldb-1.18.drv-0/source/libleveldb.dylib.1
There was a problem hiding this comment.
It is not correct that libleveldb.dylib, libleveldb.dylib.1, libleveldb.dylib.1.18 are just copies and not symlinks. However, I propose to just use my original fix. This is because the issue is temporary and will likely be gone by next release of leveldb that is going to use cmake.
There was a problem hiding this comment.
That's fine, just mentioned in case you didn't know about it 😄
GrahamcOfBorg
added
10.rebuild-darwin: 101-500
and removed
10.rebuild-darwin: 11-100
labels
|
Success on x86_64-linux (full log) Attempted: leveldb, libevent, mesos Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: leveldb, libevent The following builds were skipped because they don't evaluate on aarch64-linux: mesos Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: leveldb, libevent, mesos Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: leveldb, libevent The following builds were skipped because they don't evaluate on aarch64-linux: mesos Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: leveldb, libevent, mesos Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: leveldb, libevent, mesos Partial log (click to expand)
|
LnL7
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Provide spark on darwin (pyspark works).
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)