Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvidia_x11 as a dependency in Theano #38851

Merged
merged 2 commits into from May 13, 2018
Merged

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Apr 12, 2018

Motivation for this change

Fixes issue #38850

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Apr 12, 2018

How does this work on non-NixOS when someone runs another version of the nvidia driver?

@smatting
Copy link
Contributor Author

I have no means to test it, so I don't know.

As a comparison, tensorflow also seems to work only on linux:

  tensorflow = callPackage ../development/python-modules/tensorflow rec {
    cudaSupport = pkgs.config.cudaSupport or false;
    inherit (pkgs.linuxPackages) nvidia_x11;
    cudatoolkit = pkgs.cudatoolkit9;
    cudnn = pkgs.cudnn_cudatoolkit9;
  };

@smatting
Copy link
Contributor Author

Should I add the possibility to build the derivation with nvidia_x11=null? That way libcuda.so should be resolved to a nvidia driver that is not installed with nixos. Following the example from tensorflow i'd still leave nvidia_x11 = pkgs.linuxPackages.nvidia_x11 as a default.

@FRidh
Copy link
Member

FRidh commented May 13, 2018

This is good enough for now. Please get rid of the merge, rebase onto master, and make sure you have a commit per package you change.

@smatting
Copy link
Contributor Author

All done.

@FRidh FRidh merged commit 91e9f1d into NixOS:master May 13, 2018
@SomeoneSerge
Copy link
Contributor

SomeoneSerge commented Mar 30, 2022

Hello! Have you tried the addOpenGLRunpath way, instead of linking directly to the hardware-dependent driver?

cc NixOS/cuda-maintainers

@FRidh
Copy link
Member

FRidh commented Mar 30, 2022

@SomeoneSerge note this is a merge from several years ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants