Add mopidy-mpris #38842
Add mopidy-mpris #38842
Conversation
|
|
||
| version = "1.4.0"; | ||
|
|
||
| src = fetchFromGitHub { |
|
|
||
| propagatedBuildInputs = with pythonPackages; [ mopidy ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Please remove this and set
checkPhase = ''
py.test
'';
| { stdenv, fetchFromGitHub, pythonPackages, mopidy }: | ||
|
|
||
| pythonPackages.buildPythonApplication rec { | ||
| name = "mopidy-mpris-${version}"; |
There was a problem hiding this comment.
Please specify pname instead.
name will automatically be set to ${pname}-${version} by buildPython*
|
I did the changes you said here, but once I ran current, uncommited state: |
|
Maybe because rsvg is written in rust and was about to compile? librsvg-2.42.2 |
|
Did this actually work without the second commit you added? |
|
It built, but I'm unsure how to test it since it should be installed with |
|
You can simply add it there, and do |
|
Thanks, I see there's a lot more to work through here before this is even remotely close to working. I'll close it for now and open a new PR once it's in a more servicable state. |
Motivation for this change
Add mopidy-mpris so that it can easily be installed with mopidy
closes #38758
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)