Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtkit: fix build #38847

Closed
wants to merge 1 commit into from
Closed

rtkit: fix build #38847

wants to merge 1 commit into from

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Apr 12, 2018

Motivation for this change

Doesn't build after dbus update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@hedning hedning mentioned this pull request Apr 12, 2018
Closed
@gebner
Copy link
Member

gebner commented Apr 12, 2018

This was just fixed by @aszlig in a7f600b

@gebner gebner closed this Apr 12, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Merge failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Merge failed

@Cypher1
Copy link

Cypher1 commented Apr 16, 2018

Hi, is there a guide on how to get changes like these on NixOS?
I've been fiddling with my nix-channels and I can't work out how to rollback/update just rtkit.

Thanks

@gebner
Copy link
Member

gebner commented Apr 17, 2018 •
edited

@Cypher1 Are you by chance on the nixos-unstable channel (look at sudo nix-channel --list)? The nixos-unstable got updated today for the first time in two weeks, and so didn't have the update until now. Check http://howoldis.herokuapp.com/ for the current channel status.

See the manual for upgrade instructions. I usually do the following:

sudo nix-channel --update
sudo nixos-rebuild switch

@Cypher1
Copy link

Cypher1 commented Apr 17, 2018 •
edited

Thanks. I was, but then tried to switch to stable to get a fix.
I went back to unstable to try this fix (with the new updates).

Must be doing something wrong still. I'm getting locale issues similar to
#38991

I'm happy to move this to a new issue if anyone is free to help.

Output from the commands you suggested.
https://pastebin.com/GhtLpMv3

Edit: Fixed it a few days ago. Had to remove stable explicitly (though it didn't seem to be in --list).
Thanks for your help.

@pbogdan pbogdan deleted the rtkit-fix-build branch December 3, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbogdan @gebner @GrahamcOfBorg @Cypher1