Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eq10q: fix build with glibc 2.27 #38855

Merged
merged 1 commit into from Apr 12, 2018
Merged

eq10q: fix build with glibc 2.27 #38855

merged 1 commit into from Apr 12, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Apr 12, 2018

Motivation for this change

Doesn't build with glibc 2.27.

/cc @magnetophon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eq10q

Partial log (click to expand)

-- Installing: /nix/store/rvdjbljvyrw97bfql1wwn48dzrfjpikr-eq10q-2.2/var/empty/local/lib/lv2/sapistaEQv2.lv2/gui/combopix/hpf.png
-- Installing: /nix/store/rvdjbljvyrw97bfql1wwn48dzrfjpikr-eq10q-2.2/var/empty/local/lib/lv2/sapistaEQv2.lv2/gui/combopix/peak.png
-- Installing: /nix/store/rvdjbljvyrw97bfql1wwn48dzrfjpikr-eq10q-2.2/var/empty/local/lib/lv2/sapistaEQv2.lv2/gui/combopix/loshelf.png
-- Installing: /nix/store/rvdjbljvyrw97bfql1wwn48dzrfjpikr-eq10q-2.2/var/empty/local/lib/lv2/sapistaEQv2.lv2/gui/icons
-- Installing: /nix/store/rvdjbljvyrw97bfql1wwn48dzrfjpikr-eq10q-2.2/var/empty/local/lib/lv2/sapistaEQv2.lv2/gui/icons/logodynamics.png
-- Installing: /nix/store/rvdjbljvyrw97bfql1wwn48dzrfjpikr-eq10q-2.2/var/empty/local/lib/lv2/sapistaEQv2.lv2/gui/icons/logoeq10q.png
-- Installing: /nix/store/rvdjbljvyrw97bfql1wwn48dzrfjpikr-eq10q-2.2/var/empty/local/lib/lv2/sapistaEQv2.lv2/gui/icons/logobassup.png
glibPreFixupPhase
post-installation fixup
/nix/store/rvdjbljvyrw97bfql1wwn48dzrfjpikr-eq10q-2.2

@magnetophon
Copy link
Member

Thanks, looks great!

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: eq10q

Partial log (click to expand)

[ 41%] Built target bassupwin
[ 43%] Linking CXX static library ../../../bin/libmidsidewin.a
[ 43%] Built target midsidewin
[ 44%] Linking CXX static library ../../../bin/libdynamicwin.a
[ 44%] Built target dynamicwin
[ 45%] Linking CXX static library ../../../bin/libeqwin.a
[ 45%] Built target eqwin
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/asgnvs5i6f4zs88qdbqclg6fy2fdn47p-eq10q-2.2.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/asgnvs5i6f4zs88qdbqclg6fy2fdn47p-eq10q-2.2.drv' failed

@Mic92 Mic92 merged commit 5a2365b into NixOS:master Apr 12, 2018
@pbogdan pbogdan deleted the eq10q-glibc-2.27 branch December 3, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbogdan @GrahamcOfBorg @magnetophon @Mic92