Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.vxi11: init at 0.9 #38058

Merged
merged 1 commit into from Apr 3, 2018
Merged

pythonPackages.vxi11: init at 0.9 #38058

merged 1 commit into from Apr 3, 2018

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Mar 29, 2018 •
edited

Motivation for this change

This is a useful package for interfacing with test and measurement equipment.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bgamari bgamari requested a review from FRidh as a code owner March 29, 2018 17:40
dotlambda
dotlambda requested changes Mar 30, 2018
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -19253,6 +19253,22 @@ EOF
};
};

vxi11 = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python packages should have a dedicated directory in pkgs/development/python-modules and be included using callPackage.

pkgs/top-level/python-packages.nix Outdated
@@ -19253,6 +19253,22 @@ EOF
};
};

vxi11 = buildPythonPackage rec {
name = "python-vxi11-0.9";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pname and version instead.

pkgs/top-level/python-packages.nix Outdated
vxi11 = buildPythonPackage rec {
name = "python-vxi11-0.9";

src = pkgs.fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi

pkgs/top-level/python-packages.nix Outdated

meta = {
description = "VXI-11 driver for controlling instruments over Ethernet";
homepage = "https://github.com/python-ivi/python-vxi11";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no quotes

@bgamari
Copy link
Contributor Author

bgamari commented Mar 30, 2018

Done.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.vxi11 python3.pkgs.vxi11

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.vxi11, python3.pkgs.vxi11

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'python_vxi11.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/0lai495pmd5da2phrick18kzwyxkrfzf-python2.7-python-vxi11-0.9
/nix/store/d49bih2m4spyvcckq1ni9h88j7vxwxmh-python3.6-python-vxi11-0.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.vxi11, python3.pkgs.vxi11

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'python_vxi11.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/g7s6mqvh9wzw9ascap24nx37hgqramgd-python2.7-python-vxi11-0.9
/nix/store/jjqlg3g9mh5ma26ckjac50m4fwn9pdfh-python3.6-python-vxi11-0.9

@dotlambda
Copy link
Member

Ran 0 tests in 0.000s

Please specify an appropriate checkPhase, e.g.

checkInputs = [ nose ];
checkPhase = ''
  nosetests
'';

or set doCheck = false if the tests require manual intervention (also add a comment on why they are disabled in that case).

@bgamari
Copy link
Contributor Author

bgamari commented Apr 3, 2018

Done.

Thanks again for the reviews!

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.vxi11 python3.pkgs.vxi11

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.vxi11, python3.pkgs.vxi11

Partial log (click to expand)

Ran 0 tests in 0.012s

OK

----------------------------------------------------------------------
Ran 0 tests in 0.019s

OK
/nix/store/9aq51h8w23v78m0lvvsb9ks94nryq369-python2.7-python-vxi11-0.9
/nix/store/w87vx5isjfc6y93vbhhhkdgas1s2sqyc-python3.6-python-vxi11-0.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.vxi11, python3.pkgs.vxi11

Partial log (click to expand)


OK
running install tests

----------------------------------------------------------------------
Ran 0 tests in 0.062s

OK
/nix/store/y856l4p4ki7mr3wlp88xhm2za380pjqv-python2.7-python-vxi11-0.9
/nix/store/q3qncf1fa2453an5w22j3ana0alns97l-python3.6-python-vxi11-0.9

@dotlambda dotlambda merged commit ef3c42b into NixOS:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @dotlambda @GrahamcOfBorg