Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: e0ae89007bad
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: e01d485ce41f
Choose a head ref
  • 4 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 29, 2018

  1. lib/generators: improve toPretty 

    * properly escape strings
* remove one check for booleans
* improve error message
    @Profpatsch
    Profpatsch committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    219ba58 View commit details
    Browse the repository at this point in the history

  2. lib/generators: improve documentation a bit

    @Profpatsch
    Profpatsch committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    a7e45fd View commit details
    Browse the repository at this point in the history

  3. lib/generators: introduce a sane default for mkValueString 

    So far, `mkValueString` defaulted to `toString`,
which is a bad match for most configuration file formats,
especially because how booleans are formatted.
This also improves error messages for unsupported types.

Add a test to codify the formatting.
    @Profpatsch
    Profpatsch committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    fa71407 View commit details
    Browse the repository at this point in the history

  4. lib/generators: add an example of overriding defaults 

    An example of overriding the `toINI` generator is added,
hopefully clarifying the expressiveness of generators.
    @Profpatsch
    Profpatsch committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    e01d485 View commit details
    Browse the repository at this point in the history