Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skopeo: 1.28 -> 1.29 #38041

Merged
merged 1 commit into from Mar 29, 2018
Merged

skopeo: 1.28 -> 1.29 #38041

merged 1 commit into from Mar 29, 2018

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Mar 29, 2018

Also add myself in the maintainer list.

cc @vdemeester

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
skopeo: 1.28 -> 1.29
919d68e 
Also add myself in the maintainer list.
vdemeester
vdemeester approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: skopeo

Partial log (click to expand)

/nix/store/fg1za1as23dw4mzgzj7i2jrh1fd9pl0a-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/btrfs_tag.sh: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/fg1za1as23dw4mzgzj7i2jrh1fd9pl0a-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/libdm_tag.sh: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/fg1za1as23dw4mzgzj7i2jrh1fd9pl0a-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make/validate-gofmt: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/fg1za1as23dw4mzgzj7i2jrh1fd9pl0a-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make/test-integration: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/fg1za1as23dw4mzgzj7i2jrh1fd9pl0a-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make/validate-vet: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/fg1za1as23dw4mzgzj7i2jrh1fd9pl0a-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make/validate-lint: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/fg1za1as23dw4mzgzj7i2jrh1fd9pl0a-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make/validate-git-marks: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/fg1za1as23dw4mzgzj7i2jrh1fd9pl0a-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
checking for references to /tmp/nix-build-skopeo-0.1.29.drv-0 in /nix/store/fg1za1as23dw4mzgzj7i2jrh1fd9pl0a-skopeo-0.1.29...
/nix/store/qzsxfqyb6xid8bxsz976fnwh7gdl3lhk-skopeo-0.1.29-bin

@nlewo nlewo merged commit 974386d into NixOS:master Mar 29, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: skopeo

Partial log (click to expand)

/nix/store/k7i7g7f8j0zlrghj1f81wv0rjcl6sgwj-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/libdm_tag.sh: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/k7i7g7f8j0zlrghj1f81wv0rjcl6sgwj-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/k7i7g7f8j0zlrghj1f81wv0rjcl6sgwj-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make/test-integration: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/k7i7g7f8j0zlrghj1f81wv0rjcl6sgwj-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make/validate-git-marks: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/k7i7g7f8j0zlrghj1f81wv0rjcl6sgwj-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make/validate-gofmt: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/k7i7g7f8j0zlrghj1f81wv0rjcl6sgwj-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make/validate-lint: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/k7i7g7f8j0zlrghj1f81wv0rjcl6sgwj-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/make/validate-vet: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/k7i7g7f8j0zlrghj1f81wv0rjcl6sgwj-skopeo-0.1.29/share/go/src/github.com/projectatomic/skopeo/hack/travis_osx.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/k7i7g7f8j0zlrghj1f81wv0rjcl6sgwj-skopeo-0.1.29...
/nix/store/fm2nrmqxhkm12mh5yl7rj9zgmfar8b33-skopeo-0.1.29-bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlewo @GrahamcOfBorg @vdemeester