nixos/gogs: allow git operations over ssh #38065
Conversation
|
+1 for adding your PR message to the commit message, because it contains valuable context (the why part). Do you know if a similar fix is needed for gitea? |
Without `ROOT_PATH` set, `gogs serv` tries to open logs in writing in its store directory. This blocks cloning or pushing over ssh, and results in a gogs internal error.
|
Context added to the commit message, thanks :) About gitea, I unfortunately have absolutely no idea, but when looking for it I came upon fa76c9a , last commit to gitea. This PR doesn't in addition add the Also, given how similar the two modules look to me (gitea looks like almost a copy-paste of gogs, with “gogs” changed to “gitea” and a few added options, mostly postgresql and ), I'm thinking it'd be better to delete one of the two (likely gitea, as it wasn't there in 17.09) before 18.03 stable, and merge the two modules together, so that we don't have to fix twice the same bugs? poke @disassembler as you introduced the gitea module. |
bjornfor
changed the title
|
Applied to master (b59570e). Thanks. |
|
Thank you! |
|
This should be backported to 18.03. I spent quite some time on figuring out why gogs was throwing internal errors on ssh. |
|
Backported to release-18.03: 0cdd824. |
|
@bjornfor thank you! |
Without
ROOT_PATHset,gogs servtries to open logs in writing in its store directory. This blocks cloning or pushing over ssh, and results in a gogs internal error.I've tested the workaround on 18.03 with