Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up suspension tests #3232

Merged
merged 3 commits into from Apr 12, 2018

Conversation

msimberg
Copy link
Contributor

General cleanup of suspension tests.

Proposed Changes

  • Use new create_thread_pool function to set elasticity flag
  • Rename throttle tests to suspend_thread_X
  • Improve general consistency of tests
  • Test all schedulers (whether they should succeed or not)

Depends on #3228 and #3230.

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser added this to the 1.1.0 milestone Mar 13, 2018
@msimberg msimberg removed this from the 1.1.0 milestone Mar 22, 2018
- Use new create_thread_pool function to set elasticity flag
- Rename throttle tests to suspend_thread_X
- Improve general consistency of tests
- Test all schedulers (whether they should succeed or not)
@msimberg msimberg merged commit 8a843d8 into STEllAR-GROUP:master Apr 12, 2018
@msimberg msimberg deleted the suspension-tests-cleanup branch April 12, 2018 13:26
@msimberg msimberg added this to the 1.2.0 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants