Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callCabal2nix: Use host platform rather than build platform for evaluation of Cabal files #36841

Merged
merged 1 commit into from Mar 12, 2018
Merged

callCabal2nix: Use host platform rather than build platform for evaluation of Cabal files #36841

merged 1 commit into from Mar 12, 2018

Conversation

kmicklas
Copy link
Contributor

Motivation for this change

The if os(...) condition feature in Cabal refers to the host platform when it gets this information from GHC.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@kmicklas kmicklas requested a review from peti as a code owner March 12, 2018 01:56
@kmicklas
Copy link
Contributor Author

cc @Ericson2314

@kmicklas kmicklas force-pushed the cabal2nix-system-hostPlatform branch from ec3da61 to f34e136 Compare March 12, 2018 02:02
@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Mar 12, 2018
@Ericson2314 Ericson2314 merged commit 13c5a57 into NixOS:master Mar 12, 2018
@Ericson2314 Ericson2314 deleted the cabal2nix-system-hostPlatform branch March 12, 2018 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmicklas @Ericson2314 @GrahamcOfBorg