Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-langserver: init at unstable-2018-03-05 #36861

Merged
merged 1 commit into from Mar 12, 2018
Merged

go-langserver: init at unstable-2018-03-05 #36861

merged 1 commit into from Mar 12, 2018

Conversation

johnchildren
Copy link
Contributor

@johnchildren johnchildren commented Mar 12, 2018 •
edited

Motivation for this change

One of the listed implementations for language servers on: http://langserver.org/

Chose the latest unstable version as there has not been a release since 2016/11/29

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

nlewo
nlewo requested changes Mar 12, 2018
View reviewed changes
pkgs/development/tools/go-langserver/default.nix Outdated
goPackagePath = "github.com/sourcegraph/go-langserver";
subPackages = [ "." ];

src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use fetchFromGithub (in order to fetch a tgz instead of a git repository)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of this behavior, interesting! I have changed it to fetchFromGitHub as requested.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have made the requested changes and added meta information!

nlewo
nlewo reviewed Mar 12, 2018
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you have to add metadatas for this package (desc, license,...).

Would you like to be the maintainer of this package? In this case, you can add yourself in the meta.maintainers list.

@johnchildren
Copy link
Contributor Author

Will add metadata shortly, am happy to become maintainer as well.

@nlewo
Copy link
Member

nlewo commented Mar 12, 2018 •
edited

@johnchildren ok cool! thx.

@GrahamcOfBorg build go-langserver

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: go-langserver

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/f1b6pq15pajrakp0yixccj462zgfbiaw-go-langserver-unstable-2018-03-05-bin/bin
patching script interpreter paths in /nix/store/f1b6pq15pajrakp0yixccj462zgfbiaw-go-langserver-unstable-2018-03-05-bin
checking for references to /build in /nix/store/f1b6pq15pajrakp0yixccj462zgfbiaw-go-langserver-unstable-2018-03-05-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/7p79xqx10x0qsah5880mddb7y6faq1yz-go-langserver-unstable-2018-03-05
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/7p79xqx10x0qsah5880mddb7y6faq1yz-go-langserver-unstable-2018-03-05
/nix/store/7p79xqx10x0qsah5880mddb7y6faq1yz-go-langserver-unstable-2018-03-05/share/go/src/github.com/sourcegraph/go-langserver/brew/generate.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/7p79xqx10x0qsah5880mddb7y6faq1yz-go-langserver-unstable-2018-03-05...
/nix/store/f1b6pq15pajrakp0yixccj462zgfbiaw-go-langserver-unstable-2018-03-05-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: go-langserver

Partial log (click to expand)

strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/85iy215v8h96gjlw4hd44shawfs3gcgx-go-langserver-unstable-2018-03-05-bin/bin
patching script interpreter paths in /nix/store/85iy215v8h96gjlw4hd44shawfs3gcgx-go-langserver-unstable-2018-03-05-bin
checking for references to /build in /nix/store/85iy215v8h96gjlw4hd44shawfs3gcgx-go-langserver-unstable-2018-03-05-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/j2dv6kxkaka4h879pzdg0mapan0srjhy-go-langserver-unstable-2018-03-05
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/j2dv6kxkaka4h879pzdg0mapan0srjhy-go-langserver-unstable-2018-03-05
/nix/store/j2dv6kxkaka4h879pzdg0mapan0srjhy-go-langserver-unstable-2018-03-05/share/go/src/github.com/sourcegraph/go-langserver/brew/generate.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/j2dv6kxkaka4h879pzdg0mapan0srjhy-go-langserver-unstable-2018-03-05...
/nix/store/85iy215v8h96gjlw4hd44shawfs3gcgx-go-langserver-unstable-2018-03-05-bin

@nlewo
Copy link
Member

nlewo commented Mar 12, 2018

So, thanks for your contribution and welcome!

@nlewo nlewo merged commit 4be7395 into NixOS:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnchildren @nlewo @GrahamcOfBorg