Update vim plugins #36856
Update vim plugins #36856
Conversation
Following up from issue NixOS#33391, building LanguageClient-neovim now requires some rust dependencies. This patch makes the plugin now longer listed in vim-plugin-names file so that it will not be automatically generated and instead lists it in non-generated plugins. Also adds rustPlatform to arguments for vim plugins set.
garbas
force-pushed
the
update-vim-plugins
branch
from
87d5f25
to
f7ae3db
Compare
|
@GrahamcOfBorg build vimPlugins |
|
No attempt on aarch64-linux The following builds were skipped because they don't evaluate on aarch64-linux: vimPlugins No log is available. |
|
No attempt on x86_64-darwin The following builds were skipped because they don't evaluate on x86_64-darwin: vimPlugins No log is available. |
| preFixup = '' | ||
| substituteInPlace "$out"/share/vim-plugins/LanguageClient-neovim/plugin/LanguageClient.vim \ | ||
| --replace "let l:command = [s:root . '/bin/languageclient']" "let l:command = ['${LanguageClient-neovim-bin}/bin/languageclient']" | ||
| ''; |
There was a problem hiding this comment.
This change was not possible with pkgs/misc/vim-plugins/vim2nix/additional-nix-code?
There was a problem hiding this comment.
@Mic92: @johnchildren tried to do it, but failed (here). But I'm sure any suggestion how to do it would be great.
There was a problem hiding this comment.
@garbas ok. let's keep it this way. vimPlugins should get a refactoring anyway. It is pretty hacky.
There was a problem hiding this comment.
👍 i agree about the hacky way and the need to refractor it.
|
Success on x86_64-linux (full log) Attempted: vimPlugins Partial log (click to expand)
|
Mic92
added
the
9.needs: port to stable
|
porting to |
samueldr
removed
the
9.needs: port to stable
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)