Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtualisation #36850

Merged
merged 3 commits into from Mar 13, 2018
Merged

Virtualisation #36850

merged 3 commits into from Mar 13, 2018

Conversation

teto
Copy link
Member

@teto teto commented Mar 12, 2018

Motivation for this change

minor polish, removes qemu warnings and make double clicking output of nixos-rebuild build-vm easier for instance.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c 7c6f434c requested a review from dezgeg March 12, 2018 09:06
@7c6f434c
Copy link
Member

@GrahamcOfBorg test nat.standalone

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux

The following builds were skipped because they don't evaluate on x86_64-linux: tests.nat.standalone

No log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.nat.standalone

Partial log (click to expand)

test script finished in 54.95s
cleaning up
killing client (pid 628)
killing server (pid 652)
killing router (pid 639)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: vde_switch: Could not remove ctl dir '/build/vde2.ctl': Directory not emptyCould not remove ctl dir '/build/vde1.ctl': Directory not empty

/nix/store/pb8lhamsv6p8prc1zklqavf0z5v15hff-vm-test-run-natStandalone

@7c6f434c
Copy link
Member

@GrahamcOfBorg test nat.standalone

@7c6f434c
Copy link
Member

Maybe I will get a more lucky amd64 builder?

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.nat.standalone

Partial log (click to expand)

test script finished in 33.61s
cleaning up
killing client (pid 594)
killing router (pid 605)
killing server (pid 616)
vde_switch: vde_switch: EOF on stdin, cleaning up and exiting
EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde2.ctl': Directory not empty
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/61gm8c0rjn29xz66kh13wpij8y1k9h0j-vm-test-run-natStandalone

@7c6f434c
Copy link
Member

@grahamc if you could look in the logs and say which builder failed to instantiate, it could be interesting. Is it version mismatch?

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.nat.standalone

Partial log (click to expand)

test script finished in 53.06s
cleaning up
killing server (pid 652)
killing router (pid 640)
killing client (pid 628)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: vde_switch: Could not remove ctl dir '/build/vde2.ctl': Directory not emptyCould not remove ctl dir '/build/vde1.ctl': Directory not empty

/nix/store/ll8x38bcrsyzxghdjp7d7bzhqnfr5fyd-vm-test-run-natStandalone

@7c6f434c 7c6f434c merged commit bfbc495 into NixOS:master Mar 13, 2018
@teto teto deleted the virtualisation branch March 13, 2018 13:44
teto added a commit to teto/nixpkgs that referenced this pull request Mar 17, 2018
@teto
qemu-vm: passing QEMU_NET_OPTS would fail
33b0ad8 
because of a change in NixOS#36850.
spotted by @jtojnar NixOS@b7a2333#commitcomment-28134992
@teto teto mentioned this pull request Mar 17, 2018
Merged
8 tasks
nlewo pushed a commit that referenced this pull request Apr 3, 2018
@teto @nlewo
qemu-vm: passing QEMU_NET_OPTS would fail
d5c26dd 
because of a change in #36850.
spotted by @jtojnar b7a2333#commitcomment-28134992

(cherry picked from commit 33b0ad8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg dezgeg approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@teto @7c6f434c @GrahamcOfBorg @dezgeg @jtojnar