Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync traversals of containers passed as r-value #3229

Closed
wants to merge 2 commits into from

Conversation

Naios
Copy link
Contributor

@Naios Naios commented Mar 12, 2018

Proposed Changes

  • This fixes the reference correctness of traverse_pack when traversing a container passed as rvalue

Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch!

@hkaiser
Copy link
Member

hkaiser commented Mar 13, 2018

@Naios could you please fix the remaining inspect check errors (https://9740-4455628-gh.circle-artifacts.com/0/tmp/circle-artifacts.pTMGwoc/hpx_inspect_report.html)? We can't move ahead with merging otherwise. Thanks!

@Naios Naios force-pushed the traverse_rvalue_container branch from 1db07f0 to edffb7f Compare March 13, 2018 09:03
@Naios
Copy link
Contributor Author

Naios commented Mar 13, 2018

@hkaiser I corrected the outstanding issue

@hkaiser
Copy link
Member

hkaiser commented Mar 15, 2018

@Naios you can ignore the AppVeyor problem (this is unrelated to your work), but could you please look into the errors reported by our pycicle CI system?

@Naios Naios force-pushed the traverse_rvalue_container branch from edffb7f to 8f9e570 Compare March 16, 2018 05:31
@Naios
Copy link
Contributor Author

Naios commented Mar 16, 2018

@hkaiser I took a look into the error, this is a greater bug with which affects the whole GCC (6.x) family.
I could reproduce it on one of my remote machines using GCC 6.3.

hpx/tests/unit/util/pack_traversal.cpp(633): test 'counter == 1U' failed in function 'void test_strategic_container_traverse()': '0' != '1'
terminate called after throwing an instance of 'std::invalid_argument'
  what():  hpx::resource::get_partitioner() can be called only after the resource partitioner has been allowed to parse the command line options.

Currently I don't have the resources to reproduce it (currently I'm missing time to do it and also I don't have an environment for debugging GCC properly).

@msimberg msimberg removed this from the 1.1.0 milestone Mar 22, 2018
@stale
Copy link

stale bot commented Jul 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the tag: wontfix label Jul 4, 2019
@stale
Copy link

stale bot commented Aug 3, 2019

This issue has been automatically closed. Please re-open if necessary.

@stale stale bot closed this Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants