New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sync traversals of containers passed as r-value #3229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent catch!
@Naios could you please fix the remaining inspect check errors (https://9740-4455628-gh.circle-artifacts.com/0/tmp/circle-artifacts.pTMGwoc/hpx_inspect_report.html)? We can't move ahead with merging otherwise. Thanks! |
1db07f0
to
edffb7f
Compare
@hkaiser I corrected the outstanding issue |
@Naios you can ignore the AppVeyor problem (this is unrelated to your work), but could you please look into the errors reported by our pycicle CI system? |
edffb7f
to
8f9e570
Compare
@hkaiser I took a look into the error, this is a greater bug with which affects the whole GCC (6.x) family.
Currently I don't have the resources to reproduce it (currently I'm missing time to do it and also I don't have an environment for debugging GCC properly). |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed. Please re-open if necessary. |
Proposed Changes
traverse_pack
when traversing a container passed as rvalue