Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtlocation: fix darwin build #36847

Merged
merged 1 commit into from Mar 13, 2018
Merged

qtlocation: fix darwin build #36847

merged 1 commit into from Mar 13, 2018

Conversation

badmutex
Copy link
Contributor

A dependency (boost) makes use of std::auto_ptr, which is no longer
supported in C++17 in Clang. This change re-enables std::auto_ptr
capabilities.

/cc ZHF #36454

This is a dependency for nextcloud-client (#36788) and owncloud-client.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" No change on Linux. On Darwin some still have build failures.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@badmutex
qtlocation: fix darwin build
833851c 
A dependency (boost) makes use of `std::auto_ptr`, which is no longer
supported in C++17 in Clang. This change re-enables `std::auto_ptr`
capabilities.
@badmutex badmutex requested a review from ttuegel as a code owner March 12, 2018 06:15
@knedlsepp
Copy link
Member

knedlsepp commented Mar 12, 2018 •
edited

I guess after boost 1.66 this won't be necessary: https://svn.boost.org/trac10/ticket/11622 , which is odd, because this should already be in 18.03.

@rnhmjoj rnhmjoj mentioned this pull request Mar 13, 2018
Merged
8 tasks
@LnL7
Copy link
Member

LnL7 commented Mar 13, 2018 •
edited

@GrahamcOfBorg build qt5.qtlocation

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qt5.qtlocation

Partial log (click to expand)

/nix/store/6py9zwpf8pyp8sjyb6908fi2kdprrnxb-qtlocation-5.10.1-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: qt5.qtlocation

Partial log (click to expand)

/nix/store/j1gnvpzwybd3hdqlqsa96x6i55dgb1qx-qtlocation-5.10.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: qt5.qtlocation

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/mfj027damanfk1bs5ww7hwdzw8w9xagi-qtlocation-5.10.1-dev/lib
patching script interpreter paths in /nix/store/mfj027damanfk1bs5ww7hwdzw8w9xagi-qtlocation-5.10.1-dev
postPatchMkspecs
fixQtModulePaths: Fixing module paths in `/nix/store/mfj027damanfk1bs5ww7hwdzw8w9xagi-qtlocation-5.10.1-dev/mkspecs/modules/qt_lib_positioning.pri'...
fixQtModulePaths: Fixing module paths in `/nix/store/mfj027damanfk1bs5ww7hwdzw8w9xagi-qtlocation-5.10.1-dev/mkspecs/modules/qt_lib_location.pri'...
fixQtModulePaths: Fixing module paths in `/nix/store/mfj027damanfk1bs5ww7hwdzw8w9xagi-qtlocation-5.10.1-dev/mkspecs/modules/qt_lib_positioning_private.pri'...
fixQtModulePaths: Fixing module paths in `/nix/store/mfj027damanfk1bs5ww7hwdzw8w9xagi-qtlocation-5.10.1-dev/mkspecs/modules/qt_lib_location_private.pri'...
postPatchMkspecs
postPatchMkspecs
/nix/store/frbnnqpdfldrh55ziydnjiwx4vv6f8lq-qtlocation-5.10.1-bin

@LnL7 LnL7 merged commit ecbb902 into NixOS:master Mar 13, 2018
@badmutex badmutex deleted the qtlocation branch March 18, 2018 13:49
@veprbl veprbl mentioned this pull request Apr 25, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@badmutex @knedlsepp @LnL7 @GrahamcOfBorg