Add optional scheduler mode parameter to create_thread_pool function #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
force-pushed
the
create-thread-pool
branch
from
97d958f
to
724a3af
Compare
hkaiser
reviewed
Mar 12, 2018
| @@ -53,7 +54,8 @@ namespace hpx { namespace resource { namespace detail | |||
|
|
|||
| private: | |||
| init_pool_data(const std::string &name, | |||
| scheduling_policy = scheduling_policy::unspecified); | |||
| scheduling_policy = scheduling_policy::unspecified, | |||
| hpx::util::optional<hpx::threads::policies::scheduler_mode> = hpx::util::nullopt); | |||
There was a problem hiding this comment.
Wouldn't it be simpler to define an enumerator value representing a 'default_mode'?
There was a problem hiding this comment.
Thanks @hkaiser once again for keeping me in check. That's a really good idea and further simplifies usage (because one can say "I want defaults plus this flag" or "I want defaults and definitely not this flag").
msimberg
force-pushed
the
create-thread-pool
branch
from
724a3af
to
2a70026
Compare
msimberg
force-pushed
the
create-thread-pool
branch
from
2a70026
to
7f4a8bc
Compare
|
@hkaiser I've rebased and updated this to add only a new enum value ( The timeout on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
default_modevalue to the scheduler mode enumcreate_thread_poolwith a default value ofdefault_modeAny background context you want to provide?
Addresses #3082, but I'm not sure what more we might want. This at least simplifies the use cases in the suspension tests (one does not need to use the callback version of
create_thread_poolanymore to change scheduler modes).