Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates youtube-dl #36843

Closed
wants to merge 2 commits into from
Closed

updates youtube-dl #36843

wants to merge 2 commits into from

Conversation

pjan
Copy link

@pjan pjan commented Mar 12, 2018

Motivation for this change

as per title

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

7c6f434c pushed a commit to 7c6f434c/nixpkgs that referenced this pull request Mar 12, 2018
@7c6f434c
youtube-dl: 2018.03.03 -> 2018.03.10
86f9623 
Fixes NixOS#36843
@7c6f434c
Copy link
Member

In general please use the package: versionX -> versionY commit format, and rebase the commit on top of master as needed instead of merging master in the branch. I also don't understand where the empty line after the hash comes from in this merge, but this is probably related to some details of how git handled the merge.

Applied to master, thanks.

@7c6f434c 7c6f434c closed this Mar 12, 2018
fpletz pushed a commit that referenced this pull request May 3, 2018
@fpletz
youtube-dl: 2018.03.03 -> 2018.03.10
88c8cb0 
Fixes #36843

(cherry picked from commit 86f9623)
@pjan pjan deleted the update_youtube-dl branch May 29, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pjan @7c6f434c @GrahamcOfBorg