Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow suspension also on static schedulers #3228

Merged
merged 1 commit into from Apr 3, 2018
Merged

Allow suspension also on static schedulers #3228

merged 1 commit into from Apr 3, 2018

Conversation

msimberg
Copy link
Contributor

This is a follow-up on the fixes in #3180 to allow suspension on static schedulers (in most cases).

Proposed Changes

  • Add a has_thread_stealing function to schedulers
  • Disallow thread suspension from the same pool if has_thread_stealing returns false
  • Allow thread (except from same pool), pool and runtime suspension on static schedulers

Any background context you want to provide?

#3179 and #3180.

@msimberg
Allow suspension also on static schedulers (in most cases)
c43ca18 
Don't allow suspending a pu on the same thread pool as the calling thread.
@hkaiser hkaiser added this to the 1.1.0 milestone Mar 12, 2018
hkaiser
hkaiser approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@msimberg msimberg mentioned this pull request Mar 12, 2018
Merged
@msimberg msimberg removed this from the 1.1.0 milestone Mar 22, 2018
@msimberg msimberg changed the title WIP: Allow suspension also on static schedulers Allow suspension also on static schedulers Mar 29, 2018
@msimberg msimberg added this to the 1.2.0 milestone Mar 29, 2018
@msimberg msimberg merged commit e122fdd into STEllAR-GROUP:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: resource_partitioner category: threadmanager type: enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msimberg @hkaiser