Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5: Drop qt-5.9 #37899

Closed
wants to merge 1 commit into from
Closed

qt5: Drop qt-5.9 #37899

wants to merge 1 commit into from

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Mar 27, 2018 •
edited

Motivation for this change

Nothing is depending on the 5.9 branch of Qt anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @ttuegel @bkchr @peterhoeg

@peterhoeg
Copy link
Member

5.9 is the latest LTS - I think we should keep carrying it.

@bkchr
Copy link
Contributor

bkchr commented Mar 27, 2018

I'm for dropping it, but if we keep it, we should update it.

@ttuegel
Copy link
Member

ttuegel commented Mar 27, 2018

5.9 is the latest LTS - I think we should keep carrying it.

In the past, I have advocated for keeping the latest branch and the latest LTS branch as these are what Qt upstream officially supports. There are other reasons to keep it: some people use Nix for Qt development, for instance. So I would prefer to keep it until a new LTS comes out.

@adisbladis
Copy link
Member Author

adisbladis commented Mar 30, 2018 •
edited

I agree. I didn't think of that 5.9 was LTS.

@adisbladis adisbladis closed this Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adisbladis @peterhoeg @bkchr @ttuegel @GrahamcOfBorg