Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virglrenderer: fix missing include #37892

Merged
merged 1 commit into from Mar 27, 2018
Merged

virglrenderer: fix missing include #37892

merged 1 commit into from Mar 27, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 26, 2018

Fix build w/musl, include required identifier
by reading manpage for fd_set.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 26, 2018

@GrahamcOfBorg build virglrenderer qemu_test

1 similar comment
@dtzWill
Copy link
Member Author

dtzWill commented Mar 26, 2018

@GrahamcOfBorg build virglrenderer qemu_test

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: virglrenderer, qemu_test

Partial log (click to expand)

patching script interpreter paths in /nix/store/ars74v66dqqbmihfssg8f1i7qzb8dlkh-SDL2-2.0.8
checking for references to /build in /nix/store/ars74v66dqqbmihfssg8f1i7qzb8dlkh-SDL2-2.0.8...
shrinking RPATHs of ELF executables and libraries in /nix/store/px60rsj02ra1z1y3f46ggvcj3biw31q0-SDL2-2.0.8-dev
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/px60rsj02ra1z1y3f46ggvcj3biw31q0-SDL2-2.0.8-dev/lib  /nix/store/px60rsj02ra1z1y3f46ggvcj3biw31q0-SDL2-2.0.8-dev/bin
patching script interpreter paths in /nix/store/px60rsj02ra1z1y3f46ggvcj3biw31q0-SDL2-2.0.8-dev
/nix/store/px60rsj02ra1z1y3f46ggvcj3biw31q0-SDL2-2.0.8-dev/bin/sdl2-config: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/px60rsj02ra1z1y3f46ggvcj3biw31q0-SDL2-2.0.8-dev...
cannot build derivation '/nix/store/g02fcf0d7ni3nvyb41qaic99i65w44fg-qemu-host-cpu-only-for-vm-tests-2.11.1.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/g02fcf0d7ni3nvyb41qaic99i65w44fg-qemu-host-cpu-only-for-vm-tests-2.11.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: virglrenderer, qemu_test

Partial log (click to expand)

                  ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:455: libusbredirhost_la-usbredirhost.lo] Error 1
make[2]: Leaving directory '/build/usbredir-0.7.1/usbredirhost'
make[1]: *** [Makefile:405: all-recursive] Error 1
make[1]: Leaving directory '/build/usbredir-0.7.1'
make: *** [Makefile:337: all] Error 2
builder for '/nix/store/i961ay8v9p8zvspfif1wrn57rkj81gp5-usbredir-0.7.1.drv' failed with exit code 2
cannot build derivation '/nix/store/g02fcf0d7ni3nvyb41qaic99i65w44fg-qemu-host-cpu-only-for-vm-tests-2.11.1.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/g02fcf0d7ni3nvyb41qaic99i65w44fg-qemu-host-cpu-only-for-vm-tests-2.11.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: qemu_test

The following builds were skipped because they don't evaluate on x86_64-darwin: virglrenderer

Partial log (click to expand)

install -d -m 0755 "/nix/store/yzcb1i679bzf8azjis7qbzh1a0r30gkr-qemu-host-cpu-only-for-vm-tests-2.11.1/bin"
install -c -m 0755 qemu-system-x86_64  "/nix/store/yzcb1i679bzf8azjis7qbzh1a0r30gkr-qemu-host-cpu-only-for-vm-tests-2.11.1/bin"
strip "/nix/store/yzcb1i679bzf8azjis7qbzh1a0r30gkr-qemu-host-cpu-only-for-vm-tests-2.11.1/bin/qemu-system-x86_64"
glibPreFixupPhase
post-installation fixup
gzipping man pages under /nix/store/yzcb1i679bzf8azjis7qbzh1a0r30gkr-qemu-host-cpu-only-for-vm-tests-2.11.1/share/man/
strip is /nix/store/5fc1zygrlgfdzkfk1hajdw81czs5v9y9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/yzcb1i679bzf8azjis7qbzh1a0r30gkr-qemu-host-cpu-only-for-vm-tests-2.11.1/bin
patching script interpreter paths in /nix/store/yzcb1i679bzf8azjis7qbzh1a0r30gkr-qemu-host-cpu-only-for-vm-tests-2.11.1
/nix/store/yzcb1i679bzf8azjis7qbzh1a0r30gkr-qemu-host-cpu-only-for-vm-tests-2.11.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: qemu_test

The following builds were skipped because they don't evaluate on x86_64-darwin: virglrenderer

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/yzcb1i679bzf8azjis7qbzh1a0r30gkr-qemu-host-cpu-only-for-vm-tests-2.11.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: qemu_test

The following builds were skipped because they don't evaluate on x86_64-darwin: virglrenderer

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/yzcb1i679bzf8azjis7qbzh1a0r30gkr-qemu-host-cpu-only-for-vm-tests-2.11.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: qemu_test

The following builds were skipped because they don't evaluate on x86_64-darwin: virglrenderer

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/yzcb1i679bzf8azjis7qbzh1a0r30gkr-qemu-host-cpu-only-for-vm-tests-2.11.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: virglrenderer, qemu_test

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pvsb8129rvq2pz23rbw4zrax4xq9a4yl-spice-0.13.3
shrinking /nix/store/pvsb8129rvq2pz23rbw4zrax4xq9a4yl-spice-0.13.3/lib/libspice-server.so.1.12.1
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pvsb8129rvq2pz23rbw4zrax4xq9a4yl-spice-0.13.3/lib
patching script interpreter paths in /nix/store/pvsb8129rvq2pz23rbw4zrax4xq9a4yl-spice-0.13.3
checking for references to /build in /nix/store/pvsb8129rvq2pz23rbw4zrax4xq9a4yl-spice-0.13.3...
cannot build derivation '/nix/store/3c8ps1c1bsgswfmjmpkzpa5n0lsppaxh-qemu-host-cpu-only-for-vm-tests-2.11.1.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/3c8ps1c1bsgswfmjmpkzpa5n0lsppaxh-qemu-host-cpu-only-for-vm-tests-2.11.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: virglrenderer, qemu_test

Partial log (click to expand)

[482/1461] Compiling C object 'src/journal/journal-client@sta/journal-file.c.o'.
ninja: build stopped: subcommand failed.
builder for '/nix/store/nhsk0sjbx5cn02jprnbydc6ix5sxd1w0-systemd-238.drv' failed with exit code 1
cannot build derivation '/nix/store/97hspnd4i71myx2mcdl0k84b42xzzshw-dbus-1.10.24.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hqjp16ix3vhzkk1c4n2h64dd63nm0agb-libusb-1.0.22.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cv54lzna5w3w7jx51na0f5h739q56ajw-libpulseaudio-11.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sw6yw1dlbvj0ckkibjaykv9s4yswflbg-usbredir-0.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4582zywr2jgvvhihpd2j7rp10m34nbgg-SDL2-2.0.8.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3c8ps1c1bsgswfmjmpkzpa5n0lsppaxh-qemu-host-cpu-only-for-vm-tests-2.11.1.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/3c8ps1c1bsgswfmjmpkzpa5n0lsppaxh-qemu-host-cpu-only-for-vm-tests-2.11.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: virglrenderer, qemu_test

Partial log (click to expand)

[481/1461] Compiling C object 'src/core/core@sta/execute.c.o'.
ninja: build stopped: subcommand failed.
builder for '/nix/store/nhsk0sjbx5cn02jprnbydc6ix5sxd1w0-systemd-238.drv' failed with exit code 1
cannot build derivation '/nix/store/97hspnd4i71myx2mcdl0k84b42xzzshw-dbus-1.10.24.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hqjp16ix3vhzkk1c4n2h64dd63nm0agb-libusb-1.0.22.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cv54lzna5w3w7jx51na0f5h739q56ajw-libpulseaudio-11.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sw6yw1dlbvj0ckkibjaykv9s4yswflbg-usbredir-0.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4582zywr2jgvvhihpd2j7rp10m34nbgg-SDL2-2.0.8.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3c8ps1c1bsgswfmjmpkzpa5n0lsppaxh-qemu-host-cpu-only-for-vm-tests-2.11.1.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/3c8ps1c1bsgswfmjmpkzpa5n0lsppaxh-qemu-host-cpu-only-for-vm-tests-2.11.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: virglrenderer, qemu_test

Partial log (click to expand)

[385/1461] Compiling C object 'src/core/core@sta/load-fragment.c.o'.
ninja: build stopped: subcommand failed.
builder for '/nix/store/nhsk0sjbx5cn02jprnbydc6ix5sxd1w0-systemd-238.drv' failed with exit code 1
cannot build derivation '/nix/store/97hspnd4i71myx2mcdl0k84b42xzzshw-dbus-1.10.24.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hqjp16ix3vhzkk1c4n2h64dd63nm0agb-libusb-1.0.22.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cv54lzna5w3w7jx51na0f5h739q56ajw-libpulseaudio-11.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sw6yw1dlbvj0ckkibjaykv9s4yswflbg-usbredir-0.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4582zywr2jgvvhihpd2j7rp10m34nbgg-SDL2-2.0.8.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3c8ps1c1bsgswfmjmpkzpa5n0lsppaxh-qemu-host-cpu-only-for-vm-tests-2.11.1.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/3c8ps1c1bsgswfmjmpkzpa5n0lsppaxh-qemu-host-cpu-only-for-vm-tests-2.11.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: virglrenderer, qemu_test

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ihln27jmvsm5xh0j1ya9pfxg96pyx55j-virglrenderer-0.6.0
shrinking /nix/store/ihln27jmvsm5xh0j1ya9pfxg96pyx55j-virglrenderer-0.6.0/bin/virgl_test_server
shrinking /nix/store/ihln27jmvsm5xh0j1ya9pfxg96pyx55j-virglrenderer-0.6.0/lib/libvirglrenderer.so.0.2.0
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ihln27jmvsm5xh0j1ya9pfxg96pyx55j-virglrenderer-0.6.0/lib  /nix/store/ihln27jmvsm5xh0j1ya9pfxg96pyx55j-virglrenderer-0.6.0/bin
patching script interpreter paths in /nix/store/ihln27jmvsm5xh0j1ya9pfxg96pyx55j-virglrenderer-0.6.0
checking for references to /tmp/nix-build-virglrenderer-0.6.0.drv-0 in /nix/store/ihln27jmvsm5xh0j1ya9pfxg96pyx55j-virglrenderer-0.6.0...
cannot build derivation ‘/nix/store/d87jfs0rbn0s12vn15b0ipywjanm1d88-qemu-host-cpu-only-for-vm-tests-2.11.1.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/d87jfs0rbn0s12vn15b0ipywjanm1d88-qemu-host-cpu-only-for-vm-tests-2.11.1.drv’ failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: virglrenderer, qemu_test

Partial log (click to expand)

  CC       nv50/nv84_video_bsp.lo
  CC       nv50/nv84_video.lo
building of '/nix/store/xg57f89b779j57s18rgzgyv2gdq81jj6-mesa-noglu-17.3.6.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/ra732k6y8cwvy931jqndqrcfs6y8v859-libGL-1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/aq7lbl037fb8v1ribb5rff3lnzmjsfn5-SDL2-2.0.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5pya976gzznj74h0xf6awjnx6h9ff4yc-epoxy-1.5.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/z1mck7xclc5ka046b4dlhnay6z37arb6-glu-9.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4sr007r3j2dd6mgyh94zg8djrv55gvrk-virglrenderer-0.6.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/g02fcf0d7ni3nvyb41qaic99i65w44fg-qemu-host-cpu-only-for-vm-tests-2.11.1.drv': 5 dependencies couldn't be built
error: build of '/nix/store/4sr007r3j2dd6mgyh94zg8djrv55gvrk-virglrenderer-0.6.0.drv', '/nix/store/g02fcf0d7ni3nvyb41qaic99i65w44fg-qemu-host-cpu-only-for-vm-tests-2.11.1.drv' failed

@dtzWill dtzWill merged commit 1c110d5 into NixOS:staging Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg