Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usbredir: -Wno-error #37891

Merged
merged 1 commit into from Mar 26, 2018
Merged

usbredir: -Wno-error #37891

merged 1 commit into from Mar 26, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 26, 2018

Already adding two -Wno-error workarounds,
instead of adding another to accomodate use of sys/cdefs.h w/musl
simplify and don't disable warnings-are-errors altogether.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: usbredir

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: usbredir

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/y2p3fqsd4dnl23iq3z36yanysr871j4k-usbredir-0.7.1/lib  /nix/store/y2p3fqsd4dnl23iq3z36yanysr871j4k-usbredir-0.7.1/sbin
patching script interpreter paths in /nix/store/y2p3fqsd4dnl23iq3z36yanysr871j4k-usbredir-0.7.1
checking for references to /build in /nix/store/y2p3fqsd4dnl23iq3z36yanysr871j4k-usbredir-0.7.1...
moving /nix/store/y2p3fqsd4dnl23iq3z36yanysr871j4k-usbredir-0.7.1/sbin/* to /nix/store/y2p3fqsd4dnl23iq3z36yanysr871j4k-usbredir-0.7.1/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/xgl6z128yp17q7h4vsq6y4r2pa9vxjnb-usbredir-0.7.1-dev
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xgl6z128yp17q7h4vsq6y4r2pa9vxjnb-usbredir-0.7.1-dev/lib
patching script interpreter paths in /nix/store/xgl6z128yp17q7h4vsq6y4r2pa9vxjnb-usbredir-0.7.1-dev
checking for references to /build in /nix/store/xgl6z128yp17q7h4vsq6y4r2pa9vxjnb-usbredir-0.7.1-dev...
/nix/store/y2p3fqsd4dnl23iq3z36yanysr871j4k-usbredir-0.7.1

@dtzWill dtzWill requested review from vcunat and dezgeg March 26, 2018 20:40
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: usbredir

Partial log (click to expand)

[367/1461] Compiling C object 'journalctl@exe/src_journal_journalctl.c.o'.
[368/1461] Compiling C object 'src/journal/journal-client@sta/sd-journal.c.o'.
[369/1461] Compiling C object 'src/login/logind-core@sta/logind-dbus.c.o'.
[370/1461] Compiling C object 'src/journal/journal-client@sta/journal-file.c.o'.
[371/1461] Compiling C object 'src/libsystemd/systemd@sta/sd-bus_bus-message.c.o'.
ninja: build stopped: subcommand failed.
builder for '/nix/store/nhsk0sjbx5cn02jprnbydc6ix5sxd1w0-systemd-238.drv' failed with exit code 1
cannot build derivation '/nix/store/hqjp16ix3vhzkk1c4n2h64dd63nm0agb-libusb-1.0.22.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/g1dmb50j0xa23rhvm8xxfsbmywlyfyhg-usbredir-0.7.1.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/g1dmb50j0xa23rhvm8xxfsbmywlyfyhg-usbredir-0.7.1.drv' failed

@dtzWill dtzWill merged commit 69cdf22 into NixOS:staging Mar 26, 2018
@dtzWill dtzWill deleted the fix/usbredir-werror branch March 26, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg