Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1a98cd304ebe
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 841ae3c9592a
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 25, 2018

  1. Thread.report_on_exception is now true by default 

    Unhandled exceptions terminating threads are shown on $stderr.

For more information, please see feature #14143.
    @nomadium
    nomadium committed Mar 25, 2018
    Copy the full SHA
    eac996c View commit details

Commits on Mar 26, 2018

  1. Merge pull request #5108 from nomadium/thread-report-on-exception-def… 

    …ault-value-is-now-true

Thread.report_on_exception default value is now true
    @enebo
    enebo authored Mar 26, 2018
    Copy the full SHA
    841ae3c View commit details
Showing with 2 additions and 2 deletions.
  1. +1 −1 core/src/main/java/org/jruby/Ruby.java
  2. +1 −1 core/src/main/java/org/jruby/RubyThread.java
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/Ruby.java
View file
Original file line number Diff line number Diff line change
@@ -1388,7 +1388,7 @@ public IRubyObject call(ThreadContext context, IRubyObject self, RubyModule claz
trueObject = new RubyBoolean.True(this);
trueObject.setFrozen(true);

reportOnException = falseObject;
reportOnException = trueObject;
}

private void initCore() {
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/RubyThread.java
View file
Original file line number Diff line number Diff line change
@@ -1730,7 +1730,7 @@ public void exceptionRaised(RaiseException exception) {
protected void printReportExceptionWarning() {
PrintStream errorStream = getRuntime().getErrorStream();
String name = threadImpl.getReportName();
errorStream.println("warning: thread \"" + name + "\" terminated with exception:");
errorStream.println("warning: thread \"" + name + "\" terminated with exception (report_on_exception is true):");
}

/**