Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtwebengine: correct how NIX_BUILD_CORES is propagated to the gn ninja #37889

Merged
merged 1 commit into from Mar 27, 2018

Conversation

coreyoconnor
Copy link
Contributor

Motivation for this change
  • without this change the ninja builder driven by gn will use as many workers as the system has cores. Which may be greater than nix build-cores.
Things done
  1. Verified load without patch exceeded expected by NIX_BUILD_CORES. Did not observe process count exceed expected.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel merged commit 6cd5667 into NixOS:master Mar 27, 2018
@ttuegel
Copy link
Member

ttuegel commented Mar 27, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants