Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gambit/gerbil on darwin #37895

Merged
merged 2 commits into from Mar 27, 2018
Merged

Enable gambit/gerbil on darwin #37895

merged 2 commits into from Mar 27, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 26, 2018 •
edited

Motivation for this change

Hi:
Gambit and gerbil are supported on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Mar 26, 2018
@LnL7
Copy link
Member

LnL7 commented Mar 26, 2018

@GrahamcOfBorg build gambit gerbil

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gambit, gerbil

Partial log (click to expand)

/nix/store/w4z5ri3kp3hh6y2k92jbxnfb4cl11d1q-gambit-4.8.9
/nix/store/q7bj0aryn8190ic0p0xdvymbk3jcagyk-gerbil-0.12-RELEASE

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gambit, gerbil

Partial log (click to expand)

  /nix/store/pjfjyyc2334yznd45xn5gikn586fln3m-leveldb-1.18
  /nix/store/v2ma0k7sxpvf4fziw4w0fcylrcmcw6c5-gambit-4.8.9
  /nix/store/xmh4fsa5rm3rljh179xn5nsm094hsb2b-gerbil-0.12-RELEASE
copying path '/nix/store/v2ma0k7sxpvf4fziw4w0fcylrcmcw6c5-gambit-4.8.9' from 'https://cache.nixos.org'...
copying path '/nix/store/pjfjyyc2334yznd45xn5gikn586fln3m-leveldb-1.18' from 'https://cache.nixos.org'...
copying path '/nix/store/46480yslyvh4fa0s4x1f2abid6fd2zc2-lmdb-0.9.21' from 'https://cache.nixos.org'...
copying path '/nix/store/283ksvqz7n0klw8w7p4rvrkryygqp54w-lmdb-0.9.21-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/xmh4fsa5rm3rljh179xn5nsm094hsb2b-gerbil-0.12-RELEASE' from 'https://cache.nixos.org'...
/nix/store/v2ma0k7sxpvf4fziw4w0fcylrcmcw6c5-gambit-4.8.9
/nix/store/xmh4fsa5rm3rljh179xn5nsm094hsb2b-gerbil-0.12-RELEASE

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gambit, gerbil

Partial log (click to expand)

DYLD_LIBRARY_PATH=..: ../gsc-boot -:~~bin=../bin,~~lib=../lib,~~include=../include -f -warnings -link -flat -o _gambit.c -preload _kernel.c _system.c _num.c _std.c _eval.c _io.c _nonstd.c _thread.c _repl.c
clang -Wno-deprecated-declarations -I"/usr/local/opt/openssl/include"   -Wno-unused -Wno-write-strings -Wdisabled-optimization -O2 -fwrapv -fno-strict-aliasing -fno-math-errno -fmodulo-sched -fomit-frame-pointer -fPIC -fno-common   -I"../include" -c -o "_io.o" -I. -DHAVE_CONFIG_H -D___GAMBITDIR="\"/nix/store/ha4sckpmy0x429f0p8pxxcnv9sknglyl-gambit-4.8.9\"" -D___SYS_TYPE_CPU="\"x86_64\"" -D___SYS_TYPE_VENDOR="\"apple\"" -D___SYS_TYPE_OS="\"darwin17.3.0\"" -D___CONFIGURE_COMMAND="\"./configure '--prefix=/nix/store/ha4sckpmy0x429f0p8pxxcnv9sknglyl-gambit-4.8.9' '--enable-single-host' '--enable-c-opt=-O2' '--enable-gcc-opts' '--enable-shared' '--enable-absolute-shared-libs' '--enable-poll' '--enable-openssl' '--enable-default-runtime-options=f8,-8,t8' 'CC=clang' 'CXX=clang++'"\" -D___OBJ_EXTENSION="\".o\"" -D___EXE_EXTENSION="\"\"" -D___BAT_EXTENSION="\"\"" -D___PRIMAL _io.c -D___LIBRARY
clang-5.0: warning: optimization flag '-fmodulo-sched' is not supported [-Wignored-optimization-argument]
clang-5.0: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
clang -Wno-deprecated-declarations -I"/usr/local/opt/openssl/include"   -Wno-unused -Wno-write-strings -Wdisabled-optimization -O2 -fwrapv -fno-strict-aliasing -fno-math-errno -fmodulo-sched -fomit-frame-pointer -fPIC -fno-common   -I"../include" -c -o "_num.o" -I. -DHAVE_CONFIG_H -D___GAMBITDIR="\"/nix/store/ha4sckpmy0x429f0p8pxxcnv9sknglyl-gambit-4.8.9\"" -D___SYS_TYPE_CPU="\"x86_64\"" -D___SYS_TYPE_VENDOR="\"apple\"" -D___SYS_TYPE_OS="\"darwin17.3.0\"" -D___CONFIGURE_COMMAND="\"./configure '--prefix=/nix/store/ha4sckpmy0x429f0p8pxxcnv9sknglyl-gambit-4.8.9' '--enable-single-host' '--enable-c-opt=-O2' '--enable-gcc-opts' '--enable-shared' '--enable-absolute-shared-libs' '--enable-poll' '--enable-openssl' '--enable-default-runtime-options=f8,-8,t8' 'CC=clang' 'CXX=clang++'"\" -D___OBJ_EXTENSION="\".o\"" -D___EXE_EXTENSION="\"\"" -D___BAT_EXTENSION="\"\"" -D___PRIMAL _num.c -D___LIBRARY
clang-5.0: warning: optimization flag '-fmodulo-sched' is not supported [-Wignored-optimization-argument]
clang-5.0: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
building of '/nix/store/cx6xw7n38hq6637plypwm6gknnf6awd0-gambit-4.8.9.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/wqa0limdjnnbsq1g2366aj2zarfdxvsy-gerbil-0.12-RELEASE.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/cx6xw7n38hq6637plypwm6gknnf6awd0-gambit-4.8.9.drv', '/nix/store/wqa0limdjnnbsq1g2366aj2zarfdxvsy-gerbil-0.12-RELEASE.drv' failed

@marsam
Copy link
Contributor Author

marsam commented Mar 27, 2018

It's failing because ofborg is currently configured with 1800s build timeout. I can definitively build it on darwin.

@LnL7
Copy link
Member

LnL7 commented Mar 27, 2018

Yeah, I'll do a local build

LnL7
LnL7 approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit c80b40a into NixOS:master Mar 27, 2018
@LnL7 LnL7 added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 27, 2018
@LnL7
Copy link
Member

LnL7 commented Mar 27, 2018

Also backported to 18.03 so the darwin channel should also get caches once it updates.

@marsam marsam deleted the feature/enable-gerbil-on-darwin branch June 9, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @LnL7 @GrahamcOfBorg