Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .rst as extension for all reStructured files we ship #2983

Merged
merged 6 commits into from Mar 17, 2018
Merged

Use .rst as extension for all reStructured files we ship #2983

merged 6 commits into from Mar 17, 2018

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Mar 15, 2018

I think I caught it all.

@Kwpolska
Copy link
Member

Update the symlinks list please.

@ralsina
Copy link
Member Author

ralsina commented Mar 15, 2018

@Kwpolska done

@Kwpolska
Copy link
Member

AppVeyor still fails:

error: [Errno 2] No such file or directory: 'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\pip-66af395j-build\\docs\\sphinx\\creating-a-theme.rst'

@Kwpolska
Copy link
Member

Did you forget to git add some files?

Kwpolska
Kwpolska requested changes Mar 15, 2018
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still fails AppVeyor tests (missing files?)

@ralsina
Copy link
Member Author

ralsina commented Mar 15, 2018

I just fixed a conflict, will take a look again later (no more time)

@ralsina
Copy link
Member Author

ralsina commented Mar 15, 2018

@Kwpolska seems to be just invariance now?

@Kwpolska
Copy link
Member

AppVeyor still fails: https://ci.appveyor.com/project/Kwpolska/nikola/build/1.0.5982

@ralsina
Copy link
Member Author

ralsina commented Mar 16, 2018

@Kwpolska I have no idea how that works on windows. The symlink is there...

@Kwpolska
Copy link
Member

I can’t see it. https://github.com/getnikola/nikola/tree/use-rst-extension/docs/sphinx

@ralsina
Copy link
Member Author

ralsina commented Mar 17, 2018

Ok, was not pushed. Let's see now.

@Kwpolska Kwpolska merged commit 10b4a15 into master Mar 17, 2018
@Kwpolska Kwpolska deleted the use-rst-extension branch March 17, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralsina @Kwpolska