pythonPackages.tkinter: fix darwin build #37141
Conversation
GrahamcOfBorg
added
6.topic: darwin
|
@GrahamcOfBorg build stabber profanity |
|
Success on x86_64-linux (full log) Attempted: profanity The following builds were skipped because they don't evaluate on x86_64-linux: stabber Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: profanity The following builds were skipped because they don't evaluate on aarch64-linux: stabber Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: profanity The following builds were skipped because they don't evaluate on x86_64-darwin: stabber Partial log (click to expand)
|
|
@GrahamcOfBorg build pythonPackages.tkinter |
|
No attempt on x86_64-darwin The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.tkinter No log is available. |
|
Success on x86_64-linux (full log) Attempted: pythonPackages.tkinter Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pythonPackages.tkinter Partial log (click to expand)
|
|
@LnL7 did I miss anything? Why doesn't the darwin build evaluate? |
|
You can't reproduce it? It's either meta.platforms or an evaluation error that ofborg somehow didn't catch. |
|
I've seen this before with Borg. Does this build work for both of you? |
|
This happened before because of an issue with @grahamc's builder, I'm not aware of any other case that would cause false negatives. |
There was a problem hiding this comment.
unpacking sources
unpacking source archive /nix/store/fm0d4jibbgsi3dpr0s685m5h254pdhsq-python-2.7.14
source root is python-2.7.14
setting SOURCE_DATE_EPOCH to timestamp 315619200 of file python-2.7.14/share/man/man1/python2.7.1.gz
patching sources
configuring
no configure script, doing nothing
building
no Makefile, doing nothing
installing
/nix/store/0igxxngigjgfkgg3cw547n92b8bpg6b1-stdenv-darwin/setup: line 1233: patchelf: command not found
builder for '/nix/store/6agv8zz900y5v6kah1nhllrx9pgjy10z-python2.7-tkinter-2.7.14.drv' failed with exit code 127
error: build of '/nix/store/6agv8zz900y5v6kah1nhllrx9pgjy10z-python2.7-tkinter-2.7.14.drv' on 'ssh://mac1' failed: builder for '/nix/store/6agv8zz900y5v6kah1nhllrx9pgjy10z-python2.7-tkinter-2.7.14.drv' failed with exit code 127
builder for '/nix/store/6agv8zz900y5v6kah1nhllrx9pgjy10z-python2.7-tkinter-2.7.14.drv' failed with exit code 1
error: build of '/nix/store/6agv8zz900y5v6kah1nhllrx9pgjy10z-python2.7-tkinter-2.7.14.drv' failed
|
Hm. That's odd. I'll try to figure out why it's not working. I didn't have that issue when creating the PR. |
|
Ofborg tests the merge, maybe something else broke it. |
|
if something else broke a rebase should help. |
|
It doesn't evaluate on Darwin because it is not supported on Darwin: |
|
For more clarity: |
|
Ah, right, in In any case, one could test here the derivation |
|
I'm working to add evaluation outputs to these messages, but it is a bit complicated. For now, if the evaluator gives you confusing results, you might try testing yourself via the same command, also documented here: https://github.com/nixos/ofborg#how-does-ofborg-call-nix-instantiate |
|
@GrahamcOfBorg eval |
|
Oh. My bad. I must have mixed something up when building this on my machine. |
knedlsepp
force-pushed
the
fix-python-tkinter-on-darwin
branch
from
69f299e
to
af0f9fa
Compare
|
This should fix it now. When I tested this originally, I just built |
|
@GrahamcOfBorg build pythonPackages.tkinter |
|
Success on x86_64-linux (full log) Attempted: pythonPackages.tkinter Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pythonPackages.tkinter Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: pythonPackages.tkinter Partial log (click to expand)
|
|
There we go 😄 |
|
For nix morons like me, that get here and don't have tkinter and use nix-darwin: environment.systemPackages = worked for me: $ /run/current-system/sw/bin/python3
Python 3.6.4 (default, Mar 21 2018, 14:15:32)
[GCC 4.2.1 Compatible Clang 5.0.1 (tags/RELEASE_501/final)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import tkinter
>>> |
Motivation for this change
18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)
I looked over to homebrew for how they build their python and took the lovely patch:
https://github.com/Homebrew/homebrew-core/blob/8d530a70f8fcf02129d924090d73efbe12ff438d/Formula/python.rb#L378-L425
Fixes #10667
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)