Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pypi2nix: update to current git master #37135

Closed
wants to merge 1 commit into from
Closed

pypi2nix: update to current git master #37135

wants to merge 1 commit into from

Conversation

Fuuzetsu
Copy link
Member

1.8.1 is pretty old now and there are some nice commits in git

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Fuuzetsu
pypi2nix: update to current git master
14aa327 
1.8.1 is pretty old now and there are some nice commits in git
@Fuuzetsu Fuuzetsu requested a review from garbas March 15, 2018 18:27
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pypi2nix

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7vy4w6b42261y6v741nh1k5jbmgn0ay3-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7vy4w6b42261y6v741nh1k5jbmgn0ay3-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d/bin
patching script interpreter paths in /nix/store/7vy4w6b42261y6v741nh1k5jbmgn0ay3-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d
/nix/store/7vy4w6b42261y6v741nh1k5jbmgn0ay3-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d/pkgs/requests/packages/chardet/chardetect.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/9yr86q335k2k5ccznfcxsw0dq11zrwsw-python3-3.6.4/bin/python"
checking for references to /build in /nix/store/7vy4w6b42261y6v741nh1k5jbmgn0ay3-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d...
/nix/store/7vy4w6b42261y6v741nh1k5jbmgn0ay3-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pypi2nix

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/swljrzfim1n74djiqgi3a9h9kfbc32al-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/swljrzfim1n74djiqgi3a9h9kfbc32al-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d/bin
patching script interpreter paths in /nix/store/swljrzfim1n74djiqgi3a9h9kfbc32al-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d
/nix/store/swljrzfim1n74djiqgi3a9h9kfbc32al-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d/pkgs/requests/packages/chardet/chardetect.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/p1bp0kpmxi7nzrla7n7c4waqic0a2myk-python3-3.6.4/bin/python"
checking for references to /build in /nix/store/swljrzfim1n74djiqgi3a9h9kfbc32al-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d...
/nix/store/swljrzfim1n74djiqgi3a9h9kfbc32al-pypi2nix-654c36cdb69572837cc242840e71361c156fd08d

Mic92
Mic92 reviewed Mar 16, 2018
View reviewed changes
pkgs/development/tools/pypi2nix/default.nix
@@ -4,13 +4,13 @@

let

version = "1.8.1";
version = "654c36cdb69572837cc242840e71361c156fd08d";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @garbas how about a new release?

@garbas
Copy link
Member

garbas commented Mar 16, 2018

I will do a release this weekend

@Fuuzetsu
Copy link
Member Author

ok, I'll wait for that

@Fuuzetsu Fuuzetsu closed this Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fuuzetsu @GrahamcOfBorg @garbas @Mic92