Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enlightenment: 0.22.1 -> 0.22.2 #37367

Merged
merged 1 commit into from Mar 20, 2018
Merged

enlightenment: 0.22.1 -> 0.22.2 #37367

merged 1 commit into from Mar 20, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Mar 19, 2018

Motivation for this change

Update to version 0.22.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vbgl vbgl merged commit 1857c35 into NixOS:master Mar 20, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 20, 2018

Is this error legit?

$ ./emixer
./emixer: symbol lookup error: /nix/store/39ifv3aw047n5igdss5ymzsrwz2vql4h-alsa-lib-1.1.5/lib/libasound.so.2: undefined symbol: snd_timer_stArt, version ALSA_0.9

@Mic92
Copy link
Member

Mic92 commented Mar 20, 2018

I guess it should be snd_timer_start

@vbgl
Copy link
Contributor

vbgl commented Mar 20, 2018

Upstream bug? Should this be reverted waiting for a fix?

@Mic92
Copy link
Member

Mic92 commented Mar 20, 2018 •
edited

cc @zmike regarding broken symbol lookup.

@Mic92
Copy link
Member

Mic92 commented Mar 20, 2018

@romildo can you test how this affect enlightenment?

@zmike
Copy link

zmike commented Mar 20, 2018

This is the only file which uses alsa functions:

https://git.enlightenment.org/core/enlightenment.git/tree/src/modules/mixer/lib/backends/alsa/alsa.c?h=v0.22.2

there does not seem to be any reference to that function.

I would advise holding off on shipping 22.2, there seems to be an auth issue with the lock screen affecting some users which prevents logging back in once the screen has been locked. I expect this to be resolved within the next week.

@romildo
Copy link
Contributor Author

romildo commented Mar 20, 2018

Is this error legit?

$ ./emixer
./emixer: symbol lookup error: /nix/store/39ifv3aw047n5igdss5ymzsrwz2vql4h-alsa-lib-1.1.5/lib/libasound.so.2: undefined symbol: snd_timer_stArt, version ALSA_0.9

This does not show on my NixOS system. I have pulseaudio enabled.

@romildo romildo deleted the upd.enlightenment branch March 20, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@romildo @Mic92 @vbgl @zmike @GrahamcOfBorg