Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.thumbor: mark as broken under Python 3 #37363

Merged
merged 1 commit into from Mar 19, 2018
Merged

pythonPackages.thumbor: mark as broken under Python 3 #37363

merged 1 commit into from Mar 19, 2018

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Mar 19, 2018 •
edited by dotlambda

Motivation for this change

fixes #37362

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Mar 19, 2018

Fixed in #37147

@FRidh FRidh closed this Mar 19, 2018
@FRidh FRidh reopened this Mar 19, 2018
@vaibhavsagar vaibhavsagar mentioned this pull request Mar 19, 2018
Closed
Ma27
Ma27 requested changes Mar 19, 2018
View reviewed changes
pkgs/development/python-modules/thumbor/default.nix Outdated
@@ -46,6 +46,7 @@ buildPythonPackage rec {
doCheck = false;

meta = with stdenv.lib; {
broken = isPy3k; # see https://github.com/thumbor/thumbor/issues/1004
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn’t we use the disabled property? This gives an error message which is way more helpful

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we use disabled.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updated.

@dotlambda dotlambda merged commit 67f2d3e into NixOS:master Mar 19, 2018
@vaibhavsagar vaibhavsagar deleted the break-thumbor-python3 branch March 19, 2018 09:27
@vaibhavsagar
Copy link
Member Author

Thanks!

@dotlambda
Copy link
Member

Backported in e8f7e1e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thumbor doesn't work with Python 3
5 participants
@vaibhavsagar @FRidh @dotlambda @Ma27 @GrahamcOfBorg