Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zed: remove #37380

Merged
merged 1 commit into from Mar 19, 2018
Merged

zed: remove #37380

merged 1 commit into from Mar 19, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 19, 2018

Motivation for this change

zed is obviously dead and not maintained anymore
(https://zef.me/how-to-abandon-open-source-d5ebbc6e45e5).

As the last upstream commit was in 2015 we faced and will face many
issues with its dependencies due to the outdated upstream which can be
fatal when having security issues in the NodeJS ecosystem to fix.

One example is the handling of nwjs which is currently version 0.23,
but zed relies on 0.9. In order to reduce the maintenance overload
because of dead packages it's better to get rid of zed entirely.

Fixes #37361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

`zed` is obviously dead and not maintained anymore
(https://zef.me/how-to-abandon-open-source-d5ebbc6e45e5).

As the last upstream commit was in 2015 we faced and will face many
issues with its dependencies due to the outdated upstream which can be
fatal when having security issues in the NodeJS ecosystem to fix.

One example is the handling of `nwjs` which is currently version `0.23`,
but `zed` relies on `0.9`. In order to reduce the maintenance overload
because of dead packages it's better to get rid of `zed` entirely.

Fixes NixOS#37361
@globin globin merged commit 08a9e31 into NixOS:master Mar 19, 2018
@Ma27 Ma27 deleted the drop-zed-from-package-set branch March 19, 2018 17:02
@Ma27
Copy link
Member Author

Ma27 commented Mar 19, 2018

@globin can we do a backport to 18.03 to get rid of the maintenance overload because of this package entirely?

@Profpatsch
Copy link
Member

We can remove development/tools/node-webkit/nw9.nix completely now.

Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Mar 21, 2018
Obsolete since NixOS#37380 and severly outdated (NixOS#37361)

/cc @Profpatsch
@Ma27 Ma27 mentioned this pull request Mar 21, 2018
8 tasks
@Ma27
Copy link
Member Author

Ma27 commented Mar 21, 2018

done in #37568

globin pushed a commit that referenced this pull request Mar 21, 2018
Obsolete since #37380 and severly outdated (#37361)

/cc @Profpatsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zed: very ancient version of nwjs
4 participants