Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyschedule: init at 0.2.17 #37371

Closed
wants to merge 1 commit into from
Closed

pythonPackages.pyschedule: init at 0.2.17 #37371

wants to merge 1 commit into from

Conversation

ericsagnes
Copy link
Contributor

Motivation for this change

add pyschedule to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ericsagnes ericsagnes requested a review from FRidh as a code owner March 19, 2018 11:53
dotlambda
dotlambda requested changes Mar 19, 2018
View reviewed changes
pkgs/development/python-modules/pyschedule/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyschedule/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyschedule/default.nix Outdated

meta = with lib; {
homepage = "https://github.com/timnon/pyschedule";
description = "resource-constrained scheduling in python";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalize

pkgs/development/python-modules/pyschedule/default.nix Outdated Show resolved Hide resolved
@ericsagnes ericsagnes changed the title pyschedule: init at 0.2.17 pythonPackages.pyschedule: init at 0.2.17 Mar 20, 2018
@ericsagnes
Copy link
Contributor Author

Thanks for the review!
I pushed changes that should address most of the concerns.

dotlambda
dotlambda requested changes Mar 20, 2018
View reviewed changes
pkgs/development/python-modules/pyschedule/default.nix

meta = with lib; {
homepage = https://github.com/timnon/pyschedule;
description = "resource-constrained scheduling in python";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize: https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pyschedule python3.pkgs.pyschedule

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.pyschedule, python3.pkgs.pyschedule

Partial log (click to expand)



----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
builder for '/nix/store/y292dqvfjwjz6cd9scyyqsihn5qvy2wf-python3.6-pyschedule-0.2.17.drv' failed with exit code 1
error: build of '/nix/store/y292dqvfjwjz6cd9scyyqsihn5qvy2wf-python3.6-pyschedule-0.2.17.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.pyschedule, python3.pkgs.pyschedule

Partial log (click to expand)



----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=1 errors=1 failures=0>
builder for '/nix/store/cwi7dirdadhr5mn68pwc1fbmv36sh3pb-python3.6-pyschedule-0.2.17.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/cwi7dirdadhr5mn68pwc1fbmv36sh3pb-python3.6-pyschedule-0.2.17.drv' failed

@Mic92
Copy link
Member

Mic92 commented Mar 20, 2018

Is pythonPackages.requests missing?

ModuleNotFoundError: No module named 'requests'

@Mic92
Copy link
Member

Mic92 commented Nov 15, 2018

https://pypi.org/project/pyschedule/ 0.2.31 is out.

@costrouc costrouc mentioned this pull request Apr 15, 2019
Merged
10 tasks
costrouc added a commit to costrouc/nixpkgs that referenced this pull request Apr 15, 2019
@costrouc
pythonPackages.pyschedule: init at 0.2.34
b7475ac 
closes PR NixOS#37371. That PR was inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ericsagnes @dotlambda @GrahamcOfBorg @Mic92 @worldofpeace