Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(create-cycle-app): init at 4.0.0 #38077

Merged
merged 1 commit into from Apr 3, 2018
Merged

(create-cycle-app): init at 4.0.0 #38077

merged 1 commit into from Apr 3, 2018

Conversation

nyarly
Copy link
Contributor

@nyarly nyarly commented Mar 29, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nyarly
Adding create-cycle-app
4bf9fc7 
Adding create-cycle-app

Fixing removed modules
@infinisil
Copy link
Member

@GrahamcOfBorg build nodePackages.create-cycle-app

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: nodePackages.create-cycle-app

Partial log (click to expand)

Cannot nix-instantiate `nodePackages.create-cycle-app' because:
error: attribute 'create-cycle-app' in selection path 'nodePackages.create-cycle-app' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: nodePackages.create-cycle-app

Partial log (click to expand)

Cannot nix-instantiate `nodePackages.create-cycle-app' because:
�[31;1merror:�[0m attribute 'create-cycle-app' in selection path 'nodePackages.create-cycle-app' not found

@infinisil
Copy link
Member

Whoops
@GrahamcOfBorg build nodePackages_8_x.create-cycle-app

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nodePackages_8_x.create-cycle-app

Partial log (click to expand)

is-fullwidth-code-point@2.0.0 /nix/store/qngjpwj61dyzicv470fxwy51np2c5aia-node-create-cycle-app-4.0.0/lib/node_modules/create-cycle-app/node_modules/is-fullwidth-code-point
strip-ansi@4.0.0 /nix/store/qngjpwj61dyzicv470fxwy51np2c5aia-node-create-cycle-app-4.0.0/lib/node_modules/create-cycle-app/node_modules/inquirer/node_modules/strip-ansi
ansi-regex@3.0.0 /nix/store/qngjpwj61dyzicv470fxwy51np2c5aia-node-create-cycle-app-4.0.0/lib/node_modules/create-cycle-app/node_modules/inquirer/node_modules/ansi-regex
minimist@1.2.0 /nix/store/qngjpwj61dyzicv470fxwy51np2c5aia-node-create-cycle-app-4.0.0/lib/node_modules/create-cycle-app/node_modules/minimist
removed 3 packages in 2.167s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qngjpwj61dyzicv470fxwy51np2c5aia-node-create-cycle-app-4.0.0
patching script interpreter paths in /nix/store/qngjpwj61dyzicv470fxwy51np2c5aia-node-create-cycle-app-4.0.0
checking for references to /build in /nix/store/qngjpwj61dyzicv470fxwy51np2c5aia-node-create-cycle-app-4.0.0...
/nix/store/qngjpwj61dyzicv470fxwy51np2c5aia-node-create-cycle-app-4.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodePackages_8_x.create-cycle-app

Partial log (click to expand)

is-fullwidth-code-point@2.0.0 /nix/store/9kxi6dz12yqylllj3mzqm3f7p8v7fx6i-node-create-cycle-app-4.0.0/lib/node_modules/create-cycle-app/node_modules/is-fullwidth-code-point
strip-ansi@4.0.0 /nix/store/9kxi6dz12yqylllj3mzqm3f7p8v7fx6i-node-create-cycle-app-4.0.0/lib/node_modules/create-cycle-app/node_modules/inquirer/node_modules/strip-ansi
ansi-regex@3.0.0 /nix/store/9kxi6dz12yqylllj3mzqm3f7p8v7fx6i-node-create-cycle-app-4.0.0/lib/node_modules/create-cycle-app/node_modules/inquirer/node_modules/ansi-regex
minimist@1.2.0 /nix/store/9kxi6dz12yqylllj3mzqm3f7p8v7fx6i-node-create-cycle-app-4.0.0/lib/node_modules/create-cycle-app/node_modules/minimist
removed 3 packages in 2.524s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9kxi6dz12yqylllj3mzqm3f7p8v7fx6i-node-create-cycle-app-4.0.0
patching script interpreter paths in /nix/store/9kxi6dz12yqylllj3mzqm3f7p8v7fx6i-node-create-cycle-app-4.0.0
checking for references to /build in /nix/store/9kxi6dz12yqylllj3mzqm3f7p8v7fx6i-node-create-cycle-app-4.0.0...
/nix/store/9kxi6dz12yqylllj3mzqm3f7p8v7fx6i-node-create-cycle-app-4.0.0

infinisil
infinisil approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@7c6f434c 7c6f434c merged commit 713b0f7 into NixOS:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyarly @infinisil @GrahamcOfBorg @7c6f434c