Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assorted cleanups #38111

Merged
merged 5 commits into from Apr 5, 2018
Merged

assorted cleanups #38111

merged 5 commits into from Apr 5, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Mar 30, 2018

Motivation for this change

Cleanups.

Things done

Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the changes. LGTM, not merging immediately to give time for feedback from people using mainline NixOS.

@@ -72,59 +72,59 @@ let
in
{
options = {
dysnomia = {

services.dysnomia = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add dysnomia as an alias with a rename warning?

@oxij
Copy link
Member Author

oxij commented Mar 30, 2018 via email

@7c6f434c
Copy link
Member

Ah right, sorry.

@oxij
Copy link
Member Author

oxij commented Apr 4, 2018

ping?

@7c6f434c
Copy link
Member

7c6f434c commented Apr 5, 2018

OK, looks like nobody cares to request any changes.

@7c6f434c 7c6f434c merged commit 1955213 into NixOS:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants