Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible_2_5: init at 2.5.0 #38109

Merged
merged 1 commit into from Apr 19, 2018
Merged

ansible_2_5: init at 2.5.0 #38109

merged 1 commit into from Apr 19, 2018

Conversation

sengaya
Copy link
Contributor

@sengaya sengaya commented Mar 30, 2018

Motivation for this change

New ansible version 2.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Should the reference for ansible and ansible2 changed to the new version as well?

@@ -7425,6 +7425,7 @@ with pkgs;
ansible_2_2 = callPackage ../tools/admin/ansible/2.2.nix {};
ansible_2_3 = callPackage ../tools/admin/ansible/2.3.nix {};
ansible_2_4 = callPackage ../tools/admin/ansible/2.4.nix {};
ansible_2_5 = callPackage ../tools/admin/ansible/2.5.nix {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have all of these versions?

/cc @FRidh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should clean up some older versions. I have no idea which ones to drop, that the maintainers should look into.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgeerds @joamaki can you have a look into this?

@lukateras lukateras merged commit 443af66 into NixOS:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants