Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some downloads in release-18.03 branch #38113

Closed
wants to merge 1 commit into from
Closed

Fix some downloads in release-18.03 branch #38113

wants to merge 1 commit into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 30, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl veprbl requested a review from FRidh as a code owner March 30, 2018 06:52
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cups

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/1sds79vpd7m16akjz757mbppq625wkf0-cups-2.2.6-dev/bin
patching script interpreter paths in /nix/store/1sds79vpd7m16akjz757mbppq625wkf0-cups-2.2.6-dev
/nix/store/1sds79vpd7m16akjz757mbppq625wkf0-cups-2.2.6-dev/bin/cups-config: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-cups-2.2.6.drv-0 in /nix/store/1sds79vpd7m16akjz757mbppq625wkf0-cups-2.2.6-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/cypdkp0hj039zmdnpzfraw54w4qhfclk-cups-2.2.6-man
gzipping man pages under /nix/store/cypdkp0hj039zmdnpzfraw54w4qhfclk-cups-2.2.6-man/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/cypdkp0hj039zmdnpzfraw54w4qhfclk-cups-2.2.6-man
checking for references to /tmp/nix-build-cups-2.2.6.drv-0 in /nix/store/cypdkp0hj039zmdnpzfraw54w4qhfclk-cups-2.2.6-man...
/nix/store/rlwf2qkpgn9n2yixdg6c4dgxdpr0imgl-cups-2.2.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cups

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/s4mvdgnp3c91rkfffs1sjzfiyibwmv80-cups-2.2.6-dev/bin
patching script interpreter paths in /nix/store/s4mvdgnp3c91rkfffs1sjzfiyibwmv80-cups-2.2.6-dev
/nix/store/s4mvdgnp3c91rkfffs1sjzfiyibwmv80-cups-2.2.6-dev/bin/cups-config: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/s4mvdgnp3c91rkfffs1sjzfiyibwmv80-cups-2.2.6-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/1vh2lx16zw6ikgqliizp2c6bx4v93cx5-cups-2.2.6-man
gzipping man pages under /nix/store/1vh2lx16zw6ikgqliizp2c6bx4v93cx5-cups-2.2.6-man/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/1vh2lx16zw6ikgqliizp2c6bx4v93cx5-cups-2.2.6-man
checking for references to /build in /nix/store/1vh2lx16zw6ikgqliizp2c6bx4v93cx5-cups-2.2.6-man...
/nix/store/h2ipy7ahnjzhpji0xizzk66935w47nyr-cups-2.2.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cups

Partial log (click to expand)

/nix/store/w7a7w33905cy843n1rgvpi52qnc0xwq2-cups-2.2.6-lib/lib/libcupsppdc.1.dylib: fixing dylib
/nix/store/w7a7w33905cy843n1rgvpi52qnc0xwq2-cups-2.2.6-lib/lib/libcupscgi.1.dylib: fixing dylib
strip is /nix/store/qzbvvjrkbcqczzdqdr2d7ljzk07cmd9f-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/k4vwd4fw8x6pcchcs2aypsf3ngm7slgn-cups-2.2.6-dev/bin
patching script interpreter paths in /nix/store/k4vwd4fw8x6pcchcs2aypsf3ngm7slgn-cups-2.2.6-dev
/nix/store/k4vwd4fw8x6pcchcs2aypsf3ngm7slgn-cups-2.2.6-dev/bin/cups-config: interpreter directive changed from "/bin/sh" to "/nix/store/4cq7zlsqbs3l2lf7bb3vr03xxf0v2czz-bash-4.4-p12/bin/sh"
gzipping man pages under /nix/store/adm3zfhvfq6wddiski2xvz7s8ykhprl5-cups-2.2.6-man/share/man/
strip is /nix/store/qzbvvjrkbcqczzdqdr2d7ljzk07cmd9f-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/adm3zfhvfq6wddiski2xvz7s8ykhprl5-cups-2.2.6-man
/nix/store/88if03w7wd65arww6xghvpag3kcasjvc-cups-2.2.6

dotlambda
dotlambda reviewed Mar 30, 2018
View reviewed changes
pkgs/development/python-modules/cryptography_vectors/default.nix Outdated
src = fetchPypi {
inherit pname version;
src = fetchurl {
url = "https://pypi.python.org/packages/de/35/bb4e1e0c182b4f84d9737240d774ec347bea9a7f652e098e4a063c25d24e/${pname}-${version}.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get a 404 for https://files.pythonhosted.org/packages/source/c/cryptography_vectors/cryptography_vectors-2.1.4.tar.gz.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps that was a temporary problem. Yesterday I had:

error: unable to download 'https://files.pythonhosted.org/packages/source/c/cryptography_vectors/cryptography_vectors-2.1.4.tar.gz': HTTP error 404 (curl error: No error)

Anyway, I dropped that commit.

@dotlambda
Copy link
Member

Are this issues really specific to the 18.03 branch or do they also exist in the master branch?

@veprbl
cups: fix download hash mismatch
0b13baf 
fixed-output derivation produced path '/nix/store/7g42z7ii66fr2wyjhbnhw485ndjpzfjx-cups' with sha256 hash '0p41sg6g8vmc950s1p0nbw8wjar2qfr11bvqyrlzbhi371jj4r14' instead of the expected hash '1ddgdlg9s0l2ph6l8lx1m1lx6k50gyxqi3qiwr44ppq1rxs80ny5'
@veprbl
Copy link
Member Author

veprbl commented Mar 30, 2018

@dotlambda My aim was to fix the stable branch at it was supposed to be. As for master, nixpkgs cups maintainers should decide what they want to do to deal with the upstream file change.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cups

Partial log (click to expand)

/nix/store/h2ipy7ahnjzhpji0xizzk66935w47nyr-cups-2.2.6

@dotlambda
Copy link
Member

/cc @jgeerds

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cups

Partial log (click to expand)

/nix/store/w7a7w33905cy843n1rgvpi52qnc0xwq2-cups-2.2.6-lib/lib/libcupsmime.1.dylib: fixing dylib
/nix/store/w7a7w33905cy843n1rgvpi52qnc0xwq2-cups-2.2.6-lib/lib/libcupsppdc.1.dylib: fixing dylib
strip is /nix/store/qzbvvjrkbcqczzdqdr2d7ljzk07cmd9f-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/k4vwd4fw8x6pcchcs2aypsf3ngm7slgn-cups-2.2.6-dev/bin
patching script interpreter paths in /nix/store/k4vwd4fw8x6pcchcs2aypsf3ngm7slgn-cups-2.2.6-dev
/nix/store/k4vwd4fw8x6pcchcs2aypsf3ngm7slgn-cups-2.2.6-dev/bin/cups-config: interpreter directive changed from "/bin/sh" to "/nix/store/4cq7zlsqbs3l2lf7bb3vr03xxf0v2czz-bash-4.4-p12/bin/sh"
gzipping man pages under /nix/store/adm3zfhvfq6wddiski2xvz7s8ykhprl5-cups-2.2.6-man/share/man/
strip is /nix/store/qzbvvjrkbcqczzdqdr2d7ljzk07cmd9f-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/adm3zfhvfq6wddiski2xvz7s8ykhprl5-cups-2.2.6-man
/nix/store/88if03w7wd65arww6xghvpag3kcasjvc-cups-2.2.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cups

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/1sds79vpd7m16akjz757mbppq625wkf0-cups-2.2.6-dev/bin
patching script interpreter paths in /nix/store/1sds79vpd7m16akjz757mbppq625wkf0-cups-2.2.6-dev
/nix/store/1sds79vpd7m16akjz757mbppq625wkf0-cups-2.2.6-dev/bin/cups-config: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/1sds79vpd7m16akjz757mbppq625wkf0-cups-2.2.6-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/cypdkp0hj039zmdnpzfraw54w4qhfclk-cups-2.2.6-man
gzipping man pages under /nix/store/cypdkp0hj039zmdnpzfraw54w4qhfclk-cups-2.2.6-man/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/cypdkp0hj039zmdnpzfraw54w4qhfclk-cups-2.2.6-man
checking for references to /build in /nix/store/cypdkp0hj039zmdnpzfraw54w4qhfclk-cups-2.2.6-man...
/nix/store/rlwf2qkpgn9n2yixdg6c4dgxdpr0imgl-cups-2.2.6

@vcunat vcunat self-assigned this Mar 30, 2018
vcunat added a commit that referenced this pull request Mar 30, 2018
@vcunat
cups: fix patch download without a rebuild
0c79da1 
One needs to specify git commit to make the fetch always work.
Close #38113.

(cherry picked from commit 514e3e8)
@vcunat vcunat closed this in 514e3e8 Mar 30, 2018
@veprbl veprbl deleted the release-18.03_urlfixes branch April 15, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@vcunat vcunat

Labels
6.topic: printing 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @GrahamcOfBorg @dotlambda @vcunat