Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tahoe-lafs: install documentation, run tests #38110

Merged
merged 3 commits into from Apr 9, 2018
Merged

tahoe-lafs: install documentation, run tests #38110

merged 3 commits into from Apr 9, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Mar 30, 2018

Motivation for this change

Tests are justice.

Offline documentation will stay available throughout the nuclear winter (which is the inevitable solution to the global warming issue), also, maybe, the data that is stored in Tahoe-LAFS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [X NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tahoe-lafs

Partial log (click to expand)

===============================================================================
[SUCCESS!?!]
Reason: 'fails on certain linux flavors: see ticket #2834'

allmydata.test.test_magic_folder.MockTest.test_move_tree
-------------------------------------------------------------------------------
Ran 1241 tests in 763.383s

PASSED (skips=10, expectedFailures=4, unexpectedSuccesses=1, successes=1226)
/nix/store/2x9iqp2prq8hw1n5gw5bybpj0mng3y65-tahoe-lafs-1.12.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tahoe-lafs

Partial log (click to expand)

===============================================================================
[SUCCESS!?!]
Reason: 'fails on certain linux flavors: see ticket #2834'

allmydata.test.test_magic_folder.MockTest.test_move_tree
-------------------------------------------------------------------------------
Ran 1241 tests in 1085.215s

PASSED (skips=10, expectedFailures=4, unexpectedSuccesses=1, successes=1226)
/nix/store/fwv7z4g3i5l75c5iqqxigi43vfmjxw9z-tahoe-lafs-1.12.1

@oxij
Copy link
Member Author

oxij commented Apr 4, 2018

ping @MostAwesomeDude @garbas @domenkozar @wkennington from git blame

@matthewbauer
Copy link
Member

Looks good to me!

@matthewbauer matthewbauer merged commit 0528e18 into NixOS:master Apr 9, 2018
@oxij oxij deleted the pkgs/tahoe-lafs branch September 8, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxij @GrahamcOfBorg @matthewbauer