Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flint: Always create proper so file, support blas #38120

Merged
merged 1 commit into from Apr 9, 2018
Merged

flint: Always create proper so file, support blas #38120

merged 1 commit into from Apr 9, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 30, 2018 •
edited

Motivation for this change

Flint non-deterministically sometimes does not produces the proper .so.major file. This adds a patch (from usptream) to prevent this).

While doing that I also made blas support optional and enabled tests.

Pinging maintainer @7c6f434c.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

7c6f434c commented Apr 9, 2018

@GrahamcOfBorg build arb

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: arb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: arb

Partial log (click to expand)

mkdir -p /nix/store/rnygmzknlyxk31621mzax31hly89y8gb-arb-2.8.1/include
cp  fmpr.h  arf.h  mag.h  arb.h  arb_mat.h  arb_poly.h  arb_calc.h  acb.h  acb_mat.h  acb_poly.h  acb_calc.h  acb_hypgeom.h  acb_modular.h  fmprb.h  bernoulli.h  hypgeom.h  fmpz_extras.h  partitions.h /nix/store/rnygmzknlyxk31621mzax31hly89y8gb-arb-2.8.1/include
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rnygmzknlyxk31621mzax31hly89y8gb-arb-2.8.1
shrinking /nix/store/rnygmzknlyxk31621mzax31hly89y8gb-arb-2.8.1/lib/libarb.so.1.1.1
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rnygmzknlyxk31621mzax31hly89y8gb-arb-2.8.1/lib
patching script interpreter paths in /nix/store/rnygmzknlyxk31621mzax31hly89y8gb-arb-2.8.1
checking for references to /build in /nix/store/rnygmzknlyxk31621mzax31hly89y8gb-arb-2.8.1...
/nix/store/rnygmzknlyxk31621mzax31hly89y8gb-arb-2.8.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: arb

Partial log (click to expand)

    CC   ../build/padic/test/t-mul
    CC   ../build/padic/test/t-sub
    CC   ../build/padic/test/t-exp
    CC   ../build/padic/test/t-randtest
    CC   ../build/padic/test/t-shift
    CC   ../build/padic/test/t-get_set_fmpz
    CC   ../build/padic/test/t-log
building of '/nix/store/sc081ivnb43fc94yyvllabkckbip1x8c-flint-2.5.2.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/lnpk5jbjqfpkiwhlszr88is830n5mh62-arb-2.8.1.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/lnpk5jbjqfpkiwhlszr88is830n5mh62-arb-2.8.1.drv' failed

@7c6f434c 7c6f434c merged commit 27bafa0 into NixOS:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @7c6f434c @GrahamcOfBorg