Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todiff: init at 0.4.0 #38081

Merged
merged 1 commit into from Apr 9, 2018
Merged

todiff: init at 0.4.0 #38081

merged 1 commit into from Apr 9, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Mar 29, 2018 •
edited

Motivation for this change

OK, so this is me packaging a program I wrote myself. I wouldn't do it were I the sole user on NixOS I knew of, but at least two friends of mine also started using it, so I guess it does interest at least a few people.

I still hesitated, and people on #nixos-dev told me to just package it because it would be better if I maintained it myself (at least it'd be up-to-date), so here it is, but feel free to reject if you don't think it brings substantial improvements to nixpkgs :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: todiff

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/build'
cp: -r not specified; omitting directory 'target/release/.fingerprint'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ak1mk1nl5kij57a4gs09ch7ms5d29djl-todiff-0.3.2
shrinking /nix/store/ak1mk1nl5kij57a4gs09ch7ms5d29djl-todiff-0.3.2/bin/todiff
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ak1mk1nl5kij57a4gs09ch7ms5d29djl-todiff-0.3.2/bin
patching script interpreter paths in /nix/store/ak1mk1nl5kij57a4gs09ch7ms5d29djl-todiff-0.3.2
checking for references to /build in /nix/store/ak1mk1nl5kij57a4gs09ch7ms5d29djl-todiff-0.3.2...
/nix/store/ak1mk1nl5kij57a4gs09ch7ms5d29djl-todiff-0.3.2

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: todiff

Partial log (click to expand)

cannot build derivation '/nix/store/jd5sxbq7sa5x6xzrchkypp2q87drplry-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/9qa50x766wwvaxxvd10nk1p4xviidfi2-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/qvjhfy22hgqk2lg6r3mk5ym84vj7s9h8-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/142y4gkx972zvpp0gqxhcwq9rqf7ad21-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/i55qyd3liqs7yqq0fhr94y6vk02r4jib-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/j2qmwqmgifin75d0z8wdl1968jr1s9h5-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/w7y9d8gq23lfxb4qd2yfkhc8k0z54hma-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/p7mq2zrrcpgzdvfw3kym46w1h9qv41a1-todiff-0.3.2-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/1qwagf2bcgqczrhpip7q2xjzdki4d6br-todiff-0.3.2.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/1qwagf2bcgqczrhpip7q2xjzdki4d6br-todiff-0.3.2.drv' failed

@Ekleog
Copy link
Member Author

Ekleog commented Apr 2, 2018

The failure on aarch64 appears to be due to a timeout during the build of rustc, so I'm not really sure whether it actually builds correctly there (as I don't have any access to an aarch64 machine), but I guess it does, as there's nothing special in todiff and eg. cargo is available on linux + darwin.

@Ekleog Ekleog changed the title todiff: init at 0.3.2 todiff: init at 0.4.0 Apr 8, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: todiff

Partial log (click to expand)

-r not specified; omitting directory 'target/release/examples'

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/svgjnlbwzms1xs1mkq7iklsgljf2rczb-todiff-0.4.0
shrinking /nix/store/svgjnlbwzms1xs1mkq7iklsgljf2rczb-todiff-0.4.0/bin/todiff
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/svgjnlbwzms1xs1mkq7iklsgljf2rczb-todiff-0.4.0/bin
patching script interpreter paths in /nix/store/svgjnlbwzms1xs1mkq7iklsgljf2rczb-todiff-0.4.0
checking for references to /tmp/nix-build-todiff-0.4.0.drv-0 in /nix/store/svgjnlbwzms1xs1mkq7iklsgljf2rczb-todiff-0.4.0...
/nix/store/svgjnlbwzms1xs1mkq7iklsgljf2rczb-todiff-0.4.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: todiff

Partial log (click to expand)

cannot build derivation '/nix/store/jd5sxbq7sa5x6xzrchkypp2q87drplry-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/9qa50x766wwvaxxvd10nk1p4xviidfi2-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/qvjhfy22hgqk2lg6r3mk5ym84vj7s9h8-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/142y4gkx972zvpp0gqxhcwq9rqf7ad21-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/i55qyd3liqs7yqq0fhr94y6vk02r4jib-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/j2qmwqmgifin75d0z8wdl1968jr1s9h5-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/w7y9d8gq23lfxb4qd2yfkhc8k0z54hma-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/czp4xwvknw21hz4kdx68s1i1c0m6fhwf-todiff-0.4.0-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/5a2x9i2hnigsvcm2hgylv20093hvjaxb-todiff-0.4.0.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/5a2x9i2hnigsvcm2hgylv20093hvjaxb-todiff-0.4.0.drv' failed

@matthewbauer matthewbauer merged commit cf9e5dd into NixOS:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @matthewbauer